Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MATLAB] Remove unused feather V1 MEX infrastructure and code #37203

Closed
sgilmore10 opened this issue Aug 16, 2023 · 1 comment · Fixed by #37204
Closed

[MATLAB] Remove unused feather V1 MEX infrastructure and code #37203

sgilmore10 opened this issue Aug 16, 2023 · 1 comment · Fixed by #37204
Assignees
@sgilmore10
Labels
Component: MATLAB Type: enhancement
Milestone
14.0.0

Comments

@sgilmore10
Copy link
Member

Describe the enhancement requested

Now that featherread and featherwrite have been re-implemented in terms of the new MATLAB Interface APIs (#37163 and #37047), we can remove the unused feather V1 MEX infrastructure and code.

This includes deleting the following source / header files:

  • arrow/matlab/src/cpp/arrow/matlab/feather/feather_functions.[cc][h]
  • arrow/matlab/src/cpp/arrow/matlab/feather/feather_reader.[cc][h]
  • arrow/matlab/src/cpp/arrow/matlab/feather/feather_writer.[cc][h]
  • arrow/matlab/src/cpp/arrow/matlab/feather/matlab_traits.h
  • arrow/matlab/src/cpp/arrow/matlab/feather/util/handle_status.[cc][h]
  • arrow/matlab/src/cpp/arrow/matlab/feather/util/unicode_conversion.[cc][h]
  • arrow/matlab/src/cpp/arrow/matlab/mex/call.cc
  • arrow/matlab/src/cpp/arrow/matlab/mex/mex_functions.h
  • arrow/matlab/src/cpp/arrow/matlab/mex/mex_util.[cc][h]
  • arrow/matlab/src/cpp/arrow/matlab/mex/mex_util_test.cc
  • arrow/matlab/src/cpp/arrow/matlab/api/visibility.h

The following build infrastructure files can be deleted as well:

  • arrow/matlab/build_support/common_vars.m
  • arrow/matlab/build_support/compile.m
  • arrow/matlab/build_support/test.m

Lastly, we can remove all feather V1 MEX-specific logic from the arrow/matlab/CMakeLists.txt file.

Component(s)

MATLAB
@sgilmore10
Copy link
Member Author

take

@github-actions github-actions bot mentioned this issue Aug 16, 2023
Merged
kevingurney added a commit that referenced this issue Aug 16, 2023
@sgilmore10 @kevingurney
GH-37203: [MATLAB] Remove unused feather V1 MEX infrastructure and co…
1aa5850 
…de (#37204)

### Rationale for this change

Now that `featherread` and `featherwrite` have been re-implemented in terms of the new MATLAB Interface APIs (#37163 and #37047), we can remove the unused feather V1 MEX infrastructure and code. 

### What changes are included in this PR?

1. Deleted the following source and header files that are specific to the feather V1 MEX implementation: 
    - `arrow/matlab/src/cpp/arrow/matlab/feather/feather_functions.[cc][h]`
    - `arrow/matlab/src/cpp/arrow/matlab/feather/feather_reader.[cc][h]`
    - `arrow/matlab/src/cpp/arrow/matlab/feather/feather_writer.[cc][h]`
    - `arrow/matlab/src/cpp/arrow/matlab/feather/matlab_traits.h`
    - `arrow/matlab/src/cpp/arrow/matlab/feather/util/handle_status.[cc][h]`
    - `arrow/matlab/src/cpp/arrow/matlab/feather/util/unicode_conversion.[cc][h]`
    - `arrow/matlab/src/cpp/arrow/matlab/mex/call.cc`
    - `arrow/matlab/src/cpp/arrow/matlab/mex/mex_functions.h`
    - `arrow/matlab/src/cpp/arrow/matlab/mex/mex_util.[cc][h]`
    - `arrow/matlab/src/cpp/arrow/matlab/mex/mex_util_test.cc`
    - `arrow/matlab/src/cpp/arrow/matlab/api/visibility.h`

2. Deleted the following feather V1 MEX-specific build infrastructure files: 
    - `arrow/matlab/build_support/common_vars.m`
    - `arrow/matlab/build_support/compile.m`
    - `arrow/matlab/build_support/test.m`

3. Removed all feather V1 MEX-specific logic from the `arrow/matlab/CMakeLists.txt` file.

### Are these changes tested?

No tests are needed. The old feather V1 MEX specific implementation is unused code.

### Are there any user-facing changes?

No.

### Future Directions

1. Review the back-log of stale tasks/issues that are no longer actionable and close them. For example, #27758 has already been implemented and submitted with a different issue attached. 
* Closes: #37203

Lead-authored-by: Sarah Gilmore <sgilmore@mathworks.com>
Co-authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
@kevingurney kevingurney added this to the 14.0.0 milestone Aug 16, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@sgilmore10 @kevingurney @loicalleyne
apacheGH-37203: [MATLAB] Remove unused feather V1 MEX infrastructure …
3ac9682 
…and code (apache#37204)

### Rationale for this change

Now that `featherread` and `featherwrite` have been re-implemented in terms of the new MATLAB Interface APIs (apache#37163 and apache#37047), we can remove the unused feather V1 MEX infrastructure and code. 

### What changes are included in this PR?

1. Deleted the following source and header files that are specific to the feather V1 MEX implementation: 
    - `arrow/matlab/src/cpp/arrow/matlab/feather/feather_functions.[cc][h]`
    - `arrow/matlab/src/cpp/arrow/matlab/feather/feather_reader.[cc][h]`
    - `arrow/matlab/src/cpp/arrow/matlab/feather/feather_writer.[cc][h]`
    - `arrow/matlab/src/cpp/arrow/matlab/feather/matlab_traits.h`
    - `arrow/matlab/src/cpp/arrow/matlab/feather/util/handle_status.[cc][h]`
    - `arrow/matlab/src/cpp/arrow/matlab/feather/util/unicode_conversion.[cc][h]`
    - `arrow/matlab/src/cpp/arrow/matlab/mex/call.cc`
    - `arrow/matlab/src/cpp/arrow/matlab/mex/mex_functions.h`
    - `arrow/matlab/src/cpp/arrow/matlab/mex/mex_util.[cc][h]`
    - `arrow/matlab/src/cpp/arrow/matlab/mex/mex_util_test.cc`
    - `arrow/matlab/src/cpp/arrow/matlab/api/visibility.h`

2. Deleted the following feather V1 MEX-specific build infrastructure files: 
    - `arrow/matlab/build_support/common_vars.m`
    - `arrow/matlab/build_support/compile.m`
    - `arrow/matlab/build_support/test.m`

3. Removed all feather V1 MEX-specific logic from the `arrow/matlab/CMakeLists.txt` file.

### Are these changes tested?

No tests are needed. The old feather V1 MEX specific implementation is unused code.

### Are there any user-facing changes?

No.

### Future Directions

1. Review the back-log of stale tasks/issues that are no longer actionable and close them. For example, apache#27758 has already been implemented and submitted with a different issue attached. 
* Closes: apache#37203

Lead-authored-by: Sarah Gilmore <sgilmore@mathworks.com>
Co-authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgilmore10 sgilmore10

Labels
Component: MATLAB Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37203: [MATLAB] Remove unused feather V1 MEX infrastructure and code mathworks/arrow
2 participants
@kevingurney @sgilmore10