-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++][R] Update copies of Homebrew files to reflect recent updates #28346
Comments
Jonathan Keane / @jonkeane: However the underlying problem here may be that we need to update the script (https://github.com/apache/arrow/blob/HEAD/r/tools/autobrew) in apache arrow that uses this repo to build a version of apache-arrow. The current repo is mostly intended to build libarrow for macos 10.11 and 10.13. For newer versions of macos we use this tap to build arrow: https://github.com/autobrew/homebrew-cran Also, the CRAN package now uses a much simpler script to fetch a suitable binary of libarrow (https://github.com/autobrew/scripts/blob/master/apache-arrow), it no longer has to bootstrap a homebrew installation like we did early on. |
Neal Richardson / @nealrichardson: |
Jonathan Keane / @jonkeane:
Yes, we definitely still need to test this, I thought (though I *have not* dug into this) the new autobrew scripts did the right thing for each version (Jeroen has a few different repos and his comment made it seem like our setup was always trying to pull out of backports, when it should only do that on old macOSes, but pull out of one of the newer ones on newer macOSes) |
Todd Farmer / @toddfarmer: |
Jacob Wujciak / @assignUser: There are some other changes that should obviously be excluded (download url/version + sha) but also some where I am unsure if we should also sync them down:
|
Jonathan Keane / @jonkeane: If I'm remembering correctly, https://github.com/apache/arrow/pull/12157/files#diff-4b112dbca2ece7c78e15eb8aff3218e21dd6f4b1fab7cfc9182830488f68ca58R22-R30 was basically the operative code that fixes this. If I were you, I would take the commits on my branch there and create a new branch and push forward with that since it will let you run it in CI. Though the R tests will probably segfault with the simd issue in ARROW-15678. Maybe that's fine (since it's "only" a limited number of computers that this happens on — just so happens the GH runners are one of those, apparently) or maybe we'll need to actually resolve ARROW-15678? |
Jacob Wujciak / @assignUser: Though I thought that for [ARROW-15678] we had a workaround (setting -O2) in place that should prevent the segfault? |
Jonathan Keane / @jonkeane: |
Kouhei Sutou / @kou: |
Our copies of the Homebrew formulae at https://github.com/apache/arrow/tree/master/dev/tasks/homebrew-formulae have drifted out of sync with what's currently in https://github.com/Homebrew/homebrew-core/tree/master/Formula and https://github.com/autobrew/homebrew-core/blob/master/Formula. Get them back in sync and consider automating some method of checking that they are in sync, e.g. by failing the
homebrew-cpp
andhomebrew-r-autobrew
nightly tests if our copies don't match what's in the Homebrew and autobrew repos (but only if there were changes there that weren't made in our repo, and not the inverse).Update the instructions at
https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide#ReleaseManagementGuide-UpdatingHomebrewpackages as needed.
Reporter: Ian Cook / @ianmcook
Assignee: Jacob Wujciak / @assignUser
Related issues:
PRs and other links:
Note: This issue was originally created as ARROW-12590. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: