Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-12590: [C++][R] Update copies of Homebrew files to reflect recent updates #13769

Merged
merged 39 commits into from
Aug 17, 2022
Merged

ARROW-12590: [C++][R] Update copies of Homebrew files to reflect recent updates #13769

merged 39 commits into from
Aug 17, 2022

Conversation

assignUser
Copy link
Member

Building on #12157

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

https://issues.apache.org/jira/browse/ARROW-12590

@assignUser
Copy link
Member Author

@jonkeane looks like it works 👍 takes 2x longer on macos-11 though (more features?) maybe we can add (sc)caching later to speed that up.
A sample run: https://github.com/ursacomputing/crossbow/runs/7617843476?check_suite_focus=true

Do I understand configure correctly that tools/autobrew is only used if there is a local formula?

kou
kou reviewed Aug 1, 2022
View reviewed changes
r/tools/autobrew Outdated Show resolved Hide resolved
dev/tasks/homebrew-formulae/apache-arrow.rb Outdated Show resolved Hide resolved
@assignUser assignUser marked this pull request as draft August 2, 2022 08:27
@assignUser
Copy link
Member Author

@github-actions crossbow submit r-binary-packages homebrew-r-autobrew

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Revision: 2ca1819

Submitted crossbow builds: ursacomputing/crossbow @ actions-e54e908ed9

Task Status
homebrew-r-autobrew Github Actions
r-binary-packages Github Actions

@assignUser assignUser marked this pull request as ready for review August 2, 2022 12:45
@assignUser
Copy link
Member Author

I moved fixing the python lint to https://issues.apache.org/jira/browse/ARROW-17282

@assignUser
Copy link
Member Author

I also pulled out 10.13 testing, will open separate JIRA for those.

@assignUser
Copy link
Member Author

@nealrichardson upstreaming the changes in dependencies and build flags can happen with the 9.0.0 release PR right?

@assignUser
Copy link
Member Author

@github-actions crossbow submit homebrew-r-autobrew r-binary-packages

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Revision: 27b8715

Submitted crossbow builds: ursacomputing/crossbow @ actions-515f7b9de1

Task Status
homebrew-r-autobrew Github Actions
r-binary-packages Github Actions

@nealrichardson
Copy link
Member

@nealrichardson upstreaming the changes in dependencies and build flags can happen with the 9.0.0 release PR right?

Already in progress: autobrew/homebrew-core#114 Please review and make sure we haven't missed anything.

kou
kou reviewed Aug 5, 2022
View reviewed changes
LICENSE.txt Show resolved Hide resolved
dev/tasks/homebrew-formulae/autobrew/apache-arrow-static.rb Outdated Show resolved Hide resolved
dev/tasks/homebrew-formulae/autobrew/apache-arrow-static.rb Show resolved Hide resolved
dev/tasks/r/github.macos.autobrew.yml Outdated Show resolved Hide resolved
@assignUser
Copy link
Member Author

@github-actions crossbow submit homebrew-r-autobrew

@github-actions
Copy link

Revision: 0c7b7dd

Submitted crossbow builds: ursacomputing/crossbow @ actions-06301e563c

Task Status
homebrew-r-autobrew Github Actions

@assignUser
Copy link
Member Author

@github-actions crossbow submit homebrew-r-autobrew

@github-actions
Copy link

Revision: fbfd86d

Submitted crossbow builds: ursacomputing/crossbow @ actions-9215dbc6a9

Task Status
homebrew-r-autobrew Github Actions

@assignUser
Copy link
Member Author

@github-actions crossbow submit homebrew-r-autobrew

@github-actions
Copy link

Revision: 1bd4ee2

Submitted crossbow builds: ursacomputing/crossbow @ actions-73c090d310

Task Status
homebrew-r-autobrew Github Actions

@assignUser assignUser requested a review from kou August 16, 2022 15:15
@assignUser
Copy link
Member Author

@Neal this should be done now. I will add the 10.13 runners to the nightlies in another PR.

kou
kou approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

LICENSE.txt Outdated Show resolved Hide resolved
@kou
Copy link
Member

kou commented Aug 17, 2022

@github-actions crossbow submit homebrew-r-autobrew

@github-actions
Copy link

Revision: 197f509

Submitted crossbow builds: ursacomputing/crossbow @ actions-c336cff456

Task Status
homebrew-r-autobrew Github Actions

@kou
Copy link
Member

kou commented Aug 17, 2022

@assignUser Hmm. We get a git fetch error:

https://github.com/ursacomputing/crossbow/runs/7870472001?check_suite_focus=true#step:7:572

==> Cloning https://github.com/assignUser/arrow.git
Updating /Users/voltrondata/tmp/apache-arrow--git
git config remote.origin.url https://github.com/assignUser/arrow.git
git config remote.origin.fetch \+refs/heads/master:refs/remotes/origin/master
git fetch origin
==> Checking out revision 197f509f6eb39dd40df1e0ac3a4106769ac5f884
git checkout -f 197f509f6eb39dd40df1e0ac3a4106769ac5f884 --
fatal: reference is not a tree: 197f509f6eb39dd40df1e0ac3a4106769ac5f884
Error: An exception occured within a child process:
  DownloadError: Failed to download resource "apache-arrow"
Failure while executing; `git checkout -f 197f509f6eb39dd40df1e0ac3a4106769ac5f884 --` exited with 128. Here's the output:
fatal: reference is not a tree: 197f509f6eb39dd40df1e0ac3a4106769ac5f884

Could you confirm this?

@assignUser
Copy link
Member Author

@kou the issue is with the runner, I need to modify the cleanup script. I'll start another run once I'm done with that.

@assignUser
Copy link
Member Author

@github-actions crossbow submit homebrew-r-autobrew

@github-actions
Copy link

Revision: 92904b1

Submitted crossbow builds: ursacomputing/crossbow @ actions-6bd568128d

Task Status
homebrew-r-autobrew Github Actions

@kou
Copy link
Member

kou commented Aug 17, 2022

It seems to be working.

@kou kou merged commit 70c6708 into apache:master Aug 17, 2022
@ursabot
Copy link

ursabot commented Aug 18, 2022

Benchmark runs are scheduled for baseline = 8474ee5 and contender = 70c6708. 70c6708 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.67% ⬆️0.2%] test-mac-arm
[Failed ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.85% ⬆️0.28%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 70c67086 ec2-t3-xlarge-us-east-2
[Failed] 70c67086 test-mac-arm
[Failed] 70c67086 ursa-i9-9960x
[Finished] 70c67086 ursa-thinkcentre-m75q
[Finished] 8474ee5a ec2-t3-xlarge-us-east-2
[Finished] 8474ee5a test-mac-arm
[Failed] 8474ee5a ursa-i9-9960x
[Finished] 8474ee5a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@assignUser @jonkeane @zagto
ARROW-12590: [C++][R] Update copies of Homebrew files to reflect rece…
94c8cca 
…nt updates (apache#13769)

Building on apache#12157

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@asfimport asfimport mentioned this pull request Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

@nealrichardson nealrichardson Awaiting requested review from nealrichardson

Assignees
No one assigned
Labels
Component: Python Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@assignUser @nealrichardson @kou @ursabot @jonkeane