-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-12590: [C++][R] Update copies of Homebrew files to reflect recent updates [WIP] #12157
Conversation
@github-actions crossbow submit homebrew-r-autobrew |
|
Revision: 5054ddc Submitted crossbow builds: ursacomputing/crossbow @ actions-1397
|
5054ddc
to
b26b082
Compare
@github-actions crossbow submit homebrew-r-autobrew |
Revision: b26b082 Submitted crossbow builds: ursacomputing/crossbow @ actions-1586
|
@github-actions crossbow submit homebrew-r-autobrew |
Revision: 1592565 Submitted crossbow builds: ursacomputing/crossbow @ actions-1601
|
…nt updates (apache#13769) Building on apache#12157 Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Co-authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
I came across this in a "browsing old PRs tagged with R" mission...is this still relevant? |
Getting to a point where ^^^ happens would be very helpful for keeping up with changes downstream + making sure we don't break anything. And part of that would be to do many of the updates here (if they are still in the downstream sources...). But I don't think I'll be able to get back to this to do so, so I'll close it out — but we should still come back to that issue |
This is not totally resolved (I'm getting illegal op codes on the macos 11 job). And might not be the right approach regardless. The crux of this is that our (source) nightly builds bundle the apache-arrow.rb formula, and that formula works with autobrew/homebrew-core which isn't compatible with macos 11. (Of course, we need to keep apache-arrow.rb around and use autobrew/homebrew-core for macos 10.11/10.13 which cran uses!) The approach here is to also bundle (and test!) the formula that is in autobrew/homebrew-cran on a modern macos to ensure that that works.
These should only really matter for nightly (source) builds (or someone who otherwise tries to use these formulae) since releases will use the autobrew/scripts script without using brew at all.
I have confirmed that without the formula from autobrew/homebrew-cran, running on macos 11 runners fails with:
Note: this also does not (yet) get the formulae in sync or add a check that they are still in sync with the homebrew / autobrew repos.