Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Vote email number of issues is querying JIRA and producing a wrong number #33782

Closed
raulcd opened this issue Jan 19, 2023 · 1 comment · Fixed by #33791
Closed

[Release] Vote email number of issues is querying JIRA and producing a wrong number #33782

raulcd opened this issue Jan 19, 2023 · 1 comment · Fixed by #33791
Assignees
@rok
Labels
Component: Release Type: bug
Milestone
12.0.0

Comments

@raulcd
Copy link
Member

raulcd commented Jan 19, 2023

Describe the bug, including details regarding any error messages, version, and platform.

When generating the vote email for RC 0 on 11.0.0 I've realised that the vote email generated contains the following:

This is a release consisting of 274 resolved JIRA issues[1].

This number is extracted from:

jira_url="https://issues.apache.org/jira"
  jql="project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%20${version}"
  n_resolved_issues=$(curl "${jira_url}/rest/api/2/search/?jql=${jql}" | jq ".total")

This is wrong now, we should extract this from the GitHub milestone:
https://github.com/apache/arrow/milestone/1?closed=1
I've updated this manually for the current email vote but we should fix it on the dev/release/02-source.sh script.

Component(s)

Release
@rok
Copy link
Member

rok commented Jan 19, 2023 •
edited

GraphQL API is an option:

curl -H "Authorization: bearer GITHUB_TOKEN" -X POST -d '{"query": "query {search(query: \"repo:apache/arrow is:issue is:closed milestone:11.0.0\", type: ISSUE) {issueCount}}"}' https://api.github.com/graphql | jq ".data.search.issueCount"

@github-actions github-actions bot mentioned this issue Jan 19, 2023
Merged
kou pushed a commit that referenced this issue Jan 24, 2023
@rok
GH-33782: [Release] Vote email number of issues is querying JIRA and …
22e3bed 
…producing a wrong number (#33791)

### What changes are included in this PR?

Release RC vote email now gets issue number and verify release PR's url from GitHub's GraphQL API.

### Are these changes tested?

Changes were tested stand-alone from the rest of this script.

### Are there any user-facing changes?

ARROW_GITHUB_API_TOKEN is now mandatory for generating the release vote email.
* Closes: #33782

Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 12.0.0 milestone Jan 24, 2023
vibhatha pushed a commit to vibhatha/arrow that referenced this issue Jan 24, 2023
@rok @vibhatha
apacheGH-33782: [Release] Vote email number of issues is querying JIR…
f1783af 
…A and producing a wrong number (apache#33791)

### What changes are included in this PR?

Release RC vote email now gets issue number and verify release PR's url from GitHub's GraphQL API.

### Are these changes tested?

Changes were tested stand-alone from the rest of this script.

### Are there any user-facing changes?

ARROW_GITHUB_API_TOKEN is now mandatory for generating the release vote email.
* Closes: apache#33782

Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
westonpace pushed a commit to westonpace/arrow that referenced this issue Jan 25, 2023
@rok @westonpace
apacheGH-33782: [Release] Vote email number of issues is querying JIR…
e1a5575 
…A and producing a wrong number (apache#33791)

### What changes are included in this PR?

Release RC vote email now gets issue number and verify release PR's url from GitHub's GraphQL API.

### Are these changes tested?

Changes were tested stand-alone from the rest of this script.

### Are there any user-facing changes?

ARROW_GITHUB_API_TOKEN is now mandatory for generating the release vote email.
* Closes: apache#33782

Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
@rok @sjperkins
apacheGH-33782: [Release] Vote email number of issues is querying JIR…
f3c8bb9 
…A and producing a wrong number (apache#33791)

### What changes are included in this PR?

Release RC vote email now gets issue number and verify release PR's url from GitHub's GraphQL API.

### Are these changes tested?

Changes were tested stand-alone from the rest of this script.

### Are there any user-facing changes?

ARROW_GITHUB_API_TOKEN is now mandatory for generating the release vote email.
* Closes: apache#33782

Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rok rok

Labels
Component: Release Type: bug
Projects
None yet
Milestone
12.0.0
3 participants
@kou @rok @raulcd