Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-33782: [Release] Vote email number of issues is querying JIRA and producing a wrong number #33791

Merged
merged 4 commits into from
Jan 24, 2023
Merged

GH-33782: [Release] Vote email number of issues is querying JIRA and producing a wrong number #33791

merged 4 commits into from
Jan 24, 2023

Conversation

rok
Copy link
Member

@rok rok commented Jan 19, 2023 •
edited by github-actions bot
Loading

What changes are included in this PR?

Release RC vote email now gets issue number and verify release PR's url from GitHub's GraphQL API.

Are these changes tested?

Changes were tested stand-alone from the rest of this script.

Are there any user-facing changes?

ARROW_GITHUB_API_TOKEN is now mandatory for generating the release vote email.

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #33782 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member

raulcd commented Jan 20, 2023

It seems we have to modify the test to match the new URL: https://github.com/apache/arrow/blob/master/dev/release/02-source-test.rb#L152

@rok rok force-pushed the 33782-number-of-issues branch 7 times, most recently from 5c26557 to ed0daa4 Compare January 20, 2023 18:34
@rok
Copy link
Member Author

rok commented Jan 20, 2023

@raulcd indeed. It also required some Ruby changes. I think this is ready for review.

kou
kou reviewed Jan 21, 2023
View reviewed changes
dev/release/02-source-test.rb Outdated Show resolved Hide resolved
dev/release/02-source-test.rb Outdated Show resolved Hide resolved
dev/release/02-source.sh Outdated Show resolved Hide resolved
@rok rok requested a review from kou January 22, 2023 22:24
kou
kou approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 22e3bed into apache:master Jan 24, 2023
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request Jan 24, 2023
@rok @vibhatha
apacheGH-33782: [Release] Vote email number of issues is querying JIR…
f1783af 
…A and producing a wrong number (apache#33791)

### What changes are included in this PR?

Release RC vote email now gets issue number and verify release PR's url from GitHub's GraphQL API.

### Are these changes tested?

Changes were tested stand-alone from the rest of this script.

### Are there any user-facing changes?

ARROW_GITHUB_API_TOKEN is now mandatory for generating the release vote email.
* Closes: apache#33782

Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@ursabot
Copy link

ursabot commented Jan 24, 2023

Benchmark runs are scheduled for baseline = 3cf0b4d and contender = 22e3bed. 22e3bed is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.86% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.12% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 22e3bed4 ec2-t3-xlarge-us-east-2
[Failed] 22e3bed4 test-mac-arm
[Failed] 22e3bed4 ursa-i9-9960x
[Finished] 22e3bed4 ursa-thinkcentre-m75q
[Finished] 3cf0b4d4 ec2-t3-xlarge-us-east-2
[Failed] 3cf0b4d4 test-mac-arm
[Failed] 3cf0b4d4 ursa-i9-9960x
[Finished] 3cf0b4d4 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

westonpace pushed a commit to westonpace/arrow that referenced this pull request Jan 25, 2023
@rok @westonpace
apacheGH-33782: [Release] Vote email number of issues is querying JIR…
e1a5575 
…A and producing a wrong number (apache#33791)

### What changes are included in this PR?

Release RC vote email now gets issue number and verify release PR's url from GitHub's GraphQL API.

### Are these changes tested?

Changes were tested stand-alone from the rest of this script.

### Are there any user-facing changes?

ARROW_GITHUB_API_TOKEN is now mandatory for generating the release vote email.
* Closes: apache#33782

Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
sjperkins pushed a commit to sjperkins/arrow that referenced this pull request Feb 10, 2023
@rok @sjperkins
apacheGH-33782: [Release] Vote email number of issues is querying JIR…
f3c8bb9 
…A and producing a wrong number (apache#33791)

### What changes are included in this PR?

Release RC vote email now gets issue number and verify release PR's url from GitHub's GraphQL API.

### Are these changes tested?

Changes were tested stand-alone from the rest of this script.

### Are there any user-facing changes?

ARROW_GITHUB_API_TOKEN is now mandatory for generating the release vote email.
* Closes: apache#33782

Authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

@assignUser assignUser Awaiting requested review from assignUser

@raulcd raulcd Awaiting requested review from raulcd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Release] Vote email number of issues is querying JIRA and producing a wrong number
4 participants
@rok @raulcd @ursabot @kou