Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Bump version of bundled boost to 1.81.0 #33851

Closed
nealrichardson opened this issue Jan 24, 2023 · 2 comments · Fixed by #33890
Closed

[C++] Bump version of bundled boost to 1.81.0 #33851

nealrichardson opened this issue Jan 24, 2023 · 2 comments · Fixed by #33890
Assignees
@paleolimbot
Labels
Component: C++ Type: enhancement
Milestone
12.0.0

Comments

@nealrichardson
Copy link
Member

Describe the enhancement requested

In addition to bumping the version in versions.txt, we need to update our trimmed version that we host (90% smaller than the full boost). See cpp/build-support/trim-boost.sh. Edit BOOST_VERSION and/or provide on the command line. Then upload the bundle to artifactory (see https://issues.apache.org/jira/browse/ARROW-14336).

While you're in there, you should edit the comment about uploading to https://github.com/ursa-labs/thirdparty/releases/edit/latest, which we've switched off of. (It also appears in versions.txt but isn't used anywhere else anymore.)

May also need to edit Boost_ADDITIONAL_VERSIONS in ThirdpartyToolchain.cmake. Check for other places in that file too.

Component(s)

C++
@nealrichardson nealrichardson mentioned this issue Jan 24, 2023
Closed
@kou
Copy link
Member

kou commented Jan 24, 2023

Could you use https://apache.jfrog.io/artifactory/arrow/thirdparty/ instead of https://github.com/ursa-labs/thirdparty/releases/edit/latest ?
We're using https://apache.jfrog.io/artifactory/arrow/thirdparty/ for mirror URL: https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L424

All Apache Arrow committers/PMC members can upload a file to https://apache.jfrog.io/artifactory/arrow/thirdparty/ from https://apache.jfrog.io/ui/repos/tree/General/arrow/thirdparty with their ASF account.

@nealrichardson
Copy link
Member Author

Agree @kou, part of this task should be to remove any vestigial references to the old ursalabs repo

@paleolimbot paleolimbot mentioned this issue Jan 26, 2023
Merged
@kou kou closed this as completed in #33890 Feb 7, 2023
@kou kou added this to the 12.0.0 milestone Feb 7, 2023
kou pushed a commit that referenced this issue Feb 7, 2023
@paleolimbot
GH-33851: [C++] Update bundled boost version (#33890)
d1e5cb5 
This PR updates the bundled version of Boost, as it was suggested by a maintainer of CRAN (R packaging) that the older version of boost might be responsible for an Arrow build failure on Fedora/clang (#33819).

Closes #33851.

The resulting tarball also has to be uploaded to https://apache.jfrog.io/ui/native/arrow/thirdparty/7.0.0/ (right?) to kick in and almost certainly needs to be tested through a round of CI. I'm not sure how to do either of those things but perhaps @ assignUser does?
* Closes: #33851

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Feb 7, 2023
@paleolimbot @thisisnic
apacheGH-33851: [C++] Update bundled boost version (apache#33890)
58f84a4 
This PR updates the bundled version of Boost, as it was suggested by a maintainer of CRAN (R packaging) that the older version of boost might be responsible for an Arrow build failure on Fedora/clang (apache#33819).

Closes apache#33851.

The resulting tarball also has to be uploaded to https://apache.jfrog.io/ui/native/arrow/thirdparty/7.0.0/ (right?) to kick in and almost certainly needs to be tested through a round of CI. I'm not sure how to do either of those things but perhaps @ assignUser does?
* Closes: apache#33851

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
@paleolimbot @sjperkins
apacheGH-33851: [C++] Update bundled boost version (apache#33890)
b3bbc67 
This PR updates the bundled version of Boost, as it was suggested by a maintainer of CRAN (R packaging) that the older version of boost might be responsible for an Arrow build failure on Fedora/clang (apache#33819).

Closes apache#33851.

The resulting tarball also has to be uploaded to https://apache.jfrog.io/ui/native/arrow/thirdparty/7.0.0/ (right?) to kick in and almost certainly needs to be tested through a round of CI. I'm not sure how to do either of those things but perhaps @ assignUser does?
* Closes: apache#33851

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
@paleolimbot
apacheGH-33851: [C++] Update bundled boost version (apache#33890)
329c69b 
This PR updates the bundled version of Boost, as it was suggested by a maintainer of CRAN (R packaging) that the older version of boost might be responsible for an Arrow build failure on Fedora/clang (apache#33819).

Closes apache#33851.

The resulting tarball also has to be uploaded to https://apache.jfrog.io/ui/native/arrow/thirdparty/7.0.0/ (right?) to kick in and almost certainly needs to be tested through a round of CI. I'm not sure how to do either of those things but perhaps @ assignUser does?
* Closes: apache#33851

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@paleolimbot @fatemehp
apacheGH-33851: [C++] Update bundled boost version (apache#33890)
17c9e9c 
This PR updates the bundled version of Boost, as it was suggested by a maintainer of CRAN (R packaging) that the older version of boost might be responsible for an Arrow build failure on Fedora/clang (apache#33819).

Closes apache#33851.

The resulting tarball also has to be uploaded to https://apache.jfrog.io/ui/native/arrow/thirdparty/7.0.0/ (right?) to kick in and almost certainly needs to be tested through a round of CI. I'm not sure how to do either of those things but perhaps @ assignUser does?
* Closes: apache#33851

Authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paleolimbot paleolimbot

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-33851: [C++] Update bundled boost version paleolimbot/arrow
3 participants
@kou @nealrichardson @paleolimbot