Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][FlightRPC] Add Transactions to Sqlite FlightSQL example #34219

Closed
zeroshade opened this issue Feb 16, 2023 · 0 comments · Fixed by #34220
Closed

[Go][FlightRPC] Add Transactions to Sqlite FlightSQL example #34219

zeroshade opened this issue Feb 16, 2023 · 0 comments · Fixed by #34220
Assignees
@zeroshade
Labels
Component: Developer Tools Component: FlightRPC Component: Go Type: enhancement
Milestone
12.0.0

Comments

@zeroshade
Copy link
Member

Describe the enhancement requested

Implement the BeginTransaction/EndTransaction methods for the example Sqlite FlightSQL server and properly manage the transactions when querying.

Component(s)

Developer Tools, FlightRPC, Go
@zeroshade zeroshade self-assigned this Feb 16, 2023
zeroshade added a commit to zeroshade/arrow that referenced this issue Feb 16, 2023
@zeroshade
apacheGH-34219: [Go][FlightRPC] Add Transactions to Sqlite FlightSQL …
37f4589 
…example
@github-actions github-actions bot mentioned this issue Feb 16, 2023
Merged
zeroshade added a commit that referenced this issue Feb 17, 2023
@zeroshade
GH-34219: [Go][FlightRPC] Add Transactions to Sqlite FlightSQL example (
277bd3c 
#34220)

### Rationale for this change

### What changes are included in this PR?
Implementations for BeginTransaction/EndTransaction for the SQLite3 Flight SQL example server along with handling the transactions in Execute and Update methods.

### Are these changes tested?
Yes, tests are included.

### Are there any user-facing changes?
No.

* Closes: #34219

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 12.0.0 milestone Feb 17, 2023
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@zeroshade @fatemehp
apacheGH-34219: [Go][FlightRPC] Add Transactions to Sqlite FlightSQL …
6357710 
…example (apache#34220)

### Rationale for this change

### What changes are included in this PR?
Implementations for BeginTransaction/EndTransaction for the SQLite3 Flight SQL example server along with handling the transactions in Execute and Update methods.

### Are these changes tested?
Yes, tests are included.

### Are there any user-facing changes?
No.

* Closes: apache#34219

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: Developer Tools Component: FlightRPC Component: Go Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34219: [Go][FlightRPC] Add Transactions to Sqlite FlightSQL example zeroshade/arrow
1 participant
@zeroshade