Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Update release scripts with main as new default branch #34256

Closed
Tracked by #31142
assignUser opened this issue Feb 19, 2023 · 1 comment · Fixed by #34413
Closed
Tracked by #31142

[Release] Update release scripts with main as new default branch #34256

assignUser opened this issue Feb 19, 2023 · 1 comment · Fixed by #34413
Assignees
@lafiona
Labels
Component: Developer Tools Component: Release good-first-issue Type: bug
Milestone
12.0.0

Comments

@assignUser
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

A number of the release scripts have master hardcoded

Component(s)

Release
@assignUser assignUser mentioned this issue Feb 19, 2023
Open
14 tasks
@lafiona
Copy link
Contributor

lafiona commented Feb 21, 2023

take

@github-actions github-actions bot mentioned this issue Mar 2, 2023
Merged
@kou kou closed this as completed in #34413 Mar 2, 2023
kou pushed a commit that referenced this issue Mar 2, 2023
@lafiona
GH-34256: [Dev] Update release scripts with main as new default branch (
3b9ea6d 
#34413)

### Rationale for this change
This is a follow up task after switching the `apache/arrow` default branch name from `master` to `main`. Usages of `master` were evaluated to determine whether they can be switched over to `main`.

### What changes are included in this PR?
Only once instance of usage of `master` was changed. The other usages depend on `master` being used as the default branch in external repositories.

#### This is a summary of my investigation:

`post-04-ruby.sh`
  - Modified URL to use `HEAD` instead of `master` to refer to the most updated version of the code.

 `post-12-msys2.sh`
  - The usages of `master` is referring to the default branch of `msys2/MINGW-packages`
  - Since the default branch used by the repo is still `master` this will be kept until they swap over.

`post-13-homebrew.sh`
  - The usage of `master` in this file is similar to that of `post-12-msys2.sh`. It is referring to the default branch of the `homebrew/homebrew-core` repository, which is still using `master` as the default branch.

`post-14-vcpkg.sh`
  -  The usage of `master` in this file is similar to that of `post-12-msys2.sh`. It is referring to the default branch of the `microsoft/vcpkg` repository, which is still using `master` as the default branch.

`post-15-conan.sh`
  - The usage of `master` in this file is similar to that of `post-12-msys2.sh`. It is referring to the default branch of the `conan-io/conan-center-index` repository, which is still using `master` as the default branch.

### Are these changes tested?
I verified the change in `post-04-ruby.sh` by navigating to the new URL and confirming the contents are the same as the existing URL. Additionally, existing `release` CI tests will run as part of this pull request.

### Are there any user-facing changes?
No, users nor users of the development tools should see a difference in behavior from this change.
* Closes: #34256

Authored-by: Fiona La <fionala7@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 12.0.0 milestone Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lafiona lafiona

Labels
Component: Developer Tools Component: Release good-first-issue Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34256: [Dev] Update release scripts with main as new default branch mathworks/arrow
4 participants
@kou @raulcd @lafiona @assignUser