Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-34256: [Dev] Update release scripts with main as new default branch #34413

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

lafiona
Copy link
Contributor

@lafiona lafiona commented Mar 2, 2023

Rationale for this change

This is a follow up task after switching the apache/arrow default branch name from master to main. Usages of master were evaluated to determine whether they can be switched over to main.

What changes are included in this PR?

Only once instance of usage of master was changed. The other usages depend on master being used as the default branch in external repositories.

This is a summary of my investigation:

post-04-ruby.sh

  • Modified URL to use HEAD instead of master to refer to the most updated version of the code.

post-12-msys2.sh

  • The usages of master is referring to the default branch of msys2/MINGW-packages
  • Since the default branch used by the repo is still master this will be kept until they swap over.

post-13-homebrew.sh

  • The usage of master in this file is similar to that of post-12-msys2.sh. It is referring to the default branch of the homebrew/homebrew-core repository, which is still using master as the default branch.

post-14-vcpkg.sh

  • The usage of master in this file is similar to that of post-12-msys2.sh. It is referring to the default branch of the microsoft/vcpkg repository, which is still using master as the default branch.

post-15-conan.sh

  • The usage of master in this file is similar to that of post-12-msys2.sh. It is referring to the default branch of the conan-io/conan-center-index repository, which is still using master as the default branch.

Are these changes tested?

I verified the change in post-04-ruby.sh by navigating to the new URL and confirming the contents are the same as the existing URL. Additionally, existing release CI tests will run as part of this pull request.

Are there any user-facing changes?

No, users nor users of the development tools should see a difference in behavior from this change.

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

⚠️ GitHub issue #34256 has no components, please add labels for components.

@github-actions github-actions bot added the awaiting review Awaiting review label Mar 2, 2023
@lafiona lafiona changed the title GH-34256: [Release] Update release scripts with main as new default branch GH-34256: [Dev] Update release scripts with main as new default branch Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

⚠️ GitHub issue #34256 has no components, please add labels for components.

@lafiona
Copy link
Contributor Author

lafiona commented Mar 2, 2023

I received an email requesting me to set the component for this pull request, but it seems like I might not have permission to do so. Can a reviewer set the component to Dev?

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I received an email requesting me to set the component for this pull request

It requested for the associated issue not this pull request.

but it seems like I might not have permission to do so. Can a reviewer set the component to Dev?

It seems that @raulcd did it: #34256 (comment)

@kou kou merged commit 3b9ea6d into apache:main Mar 2, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Mar 2, 2023
@ursabot
Copy link

ursabot commented Mar 2, 2023

Benchmark runs are scheduled for baseline = 5a7d89c and contender = 3b9ea6d. 3b9ea6d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.37% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.1% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 3b9ea6dd ec2-t3-xlarge-us-east-2
[Finished] 3b9ea6dd test-mac-arm
[Finished] 3b9ea6dd ursa-i9-9960x
[Finished] 3b9ea6dd ursa-thinkcentre-m75q
[Finished] 5a7d89cf ec2-t3-xlarge-us-east-2
[Failed] 5a7d89cf test-mac-arm
[Finished] 5a7d89cf ursa-i9-9960x
[Finished] 5a7d89cf ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@kevingurney kevingurney deleted the GH-34256 branch August 21, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Release] Update release scripts with main as new default branch
3 participants