Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Read IPC files with compression enabled but uncompressed buffers #34385

Closed
lidavidm opened this issue Feb 28, 2023 · 0 comments · Fixed by #34476
Closed

[Go] Read IPC files with compression enabled but uncompressed buffers #34385

lidavidm opened this issue Feb 28, 2023 · 0 comments · Fixed by #34476
Assignees
@zeroshade
Labels
Component: Go Type: bug
Milestone
12.0.0

Comments

@lidavidm
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

Observed in #15194; an IPC file with compression may still have uncompressed buffers but Go appears not to handle this (just as C++ didn't)

Component(s)

Go
@lidavidm lidavidm mentioned this issue Feb 28, 2023
Merged
zeroshade added a commit to zeroshade/arrow that referenced this issue Mar 6, 2023
@zeroshade
apacheGH-34385: [Go] Read IPC files with compression enabled but unco…
a46f497 
…mpressed buffers
@github-actions github-actions bot mentioned this issue Mar 6, 2023
Merged
zeroshade added a commit that referenced this issue Mar 7, 2023
@zeroshade
GH-34385: [Go] Read IPC files with compression enabled but uncompress…
864ba82 
…ed buffers (#34476)

### Rationale for this change
Fixing a bug in compressing buffers by prepending -1 when a buffer is not compressed due to size.

### Are these changes tested?
Unit tests added, and other tests will be enabled via integration tests in #15194

* Closes: #34385

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 12.0.0 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: Go Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34385: [Go] Read IPC files with compression enabled but uncompressed buffers zeroshade/arrow
2 participants
@lidavidm @zeroshade