-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C#] Support encoding DateOnly
and TimeOnly
values on .NET 6.
#34620
Labels
Milestone
Comments
teo-tsirpanis
changed the title
[CSharp] Support encoding
[C#] Support encoding Mar 17, 2023
DateOnly
and TimeOnly
values on .NET 6.DateOnly
and TimeOnly
values on .NET 6.
westonpace
pushed a commit
that referenced
this issue
Jul 19, 2023
### What changes are included in this PR? Date32Array and Date64Array now support DateOnly values for construction and reading on .NET 6.0 and later. Time32Array and Time64Array now support TimeOnly values for construction and reading on .NET 6.0 and later. A new TimeArrayBuilder type is used to share logic between Time32Array.Builder and Time64Array.Builder just as the DateArrayBuilder does for the date array types. ### Are these changes tested? Yes * Closes: #34620 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Weston Pace <weston.pace@gmail.com>
chelseajonesr
pushed a commit
to chelseajonesr/arrow
that referenced
this issue
Jul 20, 2023
…he#36125) ### What changes are included in this PR? Date32Array and Date64Array now support DateOnly values for construction and reading on .NET 6.0 and later. Time32Array and Time64Array now support TimeOnly values for construction and reading on .NET 6.0 and later. A new TimeArrayBuilder type is used to share logic between Time32Array.Builder and Time64Array.Builder just as the DateArrayBuilder does for the date array types. ### Are these changes tested? Yes * Closes: apache#34620 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Weston Pace <weston.pace@gmail.com>
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this issue
Aug 20, 2023
…he#36125) ### What changes are included in this PR? Date32Array and Date64Array now support DateOnly values for construction and reading on .NET 6.0 and later. Time32Array and Time64Array now support TimeOnly values for construction and reading on .NET 6.0 and later. A new TimeArrayBuilder type is used to share logic between Time32Array.Builder and Time64Array.Builder just as the DateArrayBuilder does for the date array types. ### Are these changes tested? Yes * Closes: apache#34620 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Weston Pace <weston.pace@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…he#36125) ### What changes are included in this PR? Date32Array and Date64Array now support DateOnly values for construction and reading on .NET 6.0 and later. Time32Array and Time64Array now support TimeOnly values for construction and reading on .NET 6.0 and later. A new TimeArrayBuilder type is used to share logic between Time32Array.Builder and Time64Array.Builder just as the DateArrayBuilder does for the date array types. ### Are these changes tested? Yes * Closes: apache#34620 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
.NET 6 added
DateOnly
andTimeOnly
types that encode either only a date or a wall clock time. After #34618 gets merged which multi-targets to .NET 6, we can add support for them, when encoding(Date|Time)(32|64)Array
s.I will do it.
Component(s)
C#
The text was updated successfully, but these errors were encountered: