Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Add an auto fallback solution when system Gtest is compiled with a C++ standard lower than 17. #34813

Closed
HaochengLIU opened this issue Mar 31, 2023 · 3 comments · Fixed by #34920
Closed

[C++] Add an auto fallback solution when system Gtest is compiled with a C++ standard lower than 17. #34813

HaochengLIU opened this issue Mar 31, 2023 · 3 comments · Fixed by #34920
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
12.0.0

Comments

@HaochengLIU
Copy link
Contributor

Describe the enhancement requested

in PR #34765, Arrow will error out when the detected GTest is compiled with a C++ standard lower than 17. This is a follow-up issue that should support auto fallback:

Proposed solution from @kou :

Add a FindGtestAlt.cmake file (GTestConfig.cmake is a good starting point) and use new target names to refer to suitable Arrow target. See details in this comment

Component(s)

C++
@HaochengLIU HaochengLIU mentioned this issue Mar 31, 2023
Merged
@HaochengLIU
Copy link
Contributor Author

FYI I need to tackle #34565 first in April as it's related to my job. Once it's done I will revisit this enhancement.

@westonpace
Copy link
Member

Do you mean it would fallback to building from source?

@HaochengLIU
Copy link
Contributor Author

yes, the goal is to support automatic fallback

@HaochengLIU HaochengLIU mentioned this issue Apr 3, 2023
Closed
@jorisvandenbossche jorisvandenbossche changed the title [C++] Add an auto fallback solution when system Gtest is cmpiled with a C++ standaard lower than 17. [C++] Add an auto fallback solution when system Gtest is compiled with a C++ standard lower than 17. Apr 4, 2023
@kou kou mentioned this issue Apr 5, 2023
Merged
kou added a commit to kou/arrow that referenced this issue Apr 6, 2023
@kou
apacheGH-34813: [C++] Improve GoogleTest detection
6f1eefb 
If incompatible GoogleTest is detected, we can fallback to bundled
GoogleTest automatically.
kou added a commit to kou/arrow that referenced this issue Apr 6, 2023
@kou
apacheGH-34813: [C++] Improve GoogleTest detection
c1ccc74 
If incompatible GoogleTest is detected, we can fallback to bundled
GoogleTest automatically.
kou added a commit to kou/arrow that referenced this issue Apr 6, 2023
@kou
apacheGH-34813: [C++] Improve GoogleTest detection
e6c0717 
If incompatible GoogleTest is detected, we can fallback to bundled
GoogleTest automatically.
kou added a commit to kou/arrow that referenced this issue Apr 6, 2023
@kou
apacheGH-34813: [C++] Improve GoogleTest detection
040bfbd 
If incompatible GoogleTest is detected, we can fallback to bundled
GoogleTest automatically.
@github-actions github-actions bot mentioned this issue Apr 6, 2023
Merged
kou added a commit to kou/arrow that referenced this issue Apr 6, 2023
@kou
apacheGH-34813: [C++] Improve GoogleTest detection
d8ccf7e 
If incompatible GoogleTest is detected, we can fallback to bundled
GoogleTest automatically.
kou added a commit to kou/arrow that referenced this issue Apr 6, 2023
@kou
apacheGH-34813: [C++] Improve GoogleTest detection
199647d 
If incompatible GoogleTest is detected, we can fallback to bundled
GoogleTest automatically.
kou added a commit to kou/arrow that referenced this issue Apr 6, 2023
@kou
apacheGH-34813: [C++] Improve GoogleTest detection
a48266e 
If incompatible GoogleTest is detected, we can fallback to bundled
GoogleTest automatically.
kou added a commit to kou/arrow that referenced this issue Apr 6, 2023
@kou
apacheGH-34813: [C++] Improve GoogleTest detection
536af6a 
If incompatible GoogleTest is detected, we can fallback to bundled
GoogleTest automatically.
kou added a commit to kou/arrow that referenced this issue Apr 6, 2023
@kou
apacheGH-34813: [C++] Improve GoogleTest detection
a585e35 
If incompatible GoogleTest is detected, we can fallback to bundled
GoogleTest automatically.
kou added a commit to kou/arrow that referenced this issue Apr 6, 2023
@kou
apacheGH-34813: [C++] Improve GoogleTest detection
0b9cf98 
If incompatible GoogleTest is detected, we can fallback to bundled
GoogleTest automatically.
kou added a commit to kou/arrow that referenced this issue Apr 6, 2023
@kou
apacheGH-34813: [C++] Improve GoogleTest detection
3440365 
If incompatible GoogleTest is detected, we can fallback to bundled
GoogleTest automatically.
kou added a commit to kou/arrow that referenced this issue Apr 6, 2023
@kou
apacheGH-34813: [C++] Improve GoogleTest detection
3de38f0 
If incompatible GoogleTest is detected, we can fallback to bundled
GoogleTest automatically.
kou added a commit to kou/arrow that referenced this issue Apr 6, 2023
@kou
apacheGH-34813: [C++] Improve GoogleTest detection
3815328 
If incompatible GoogleTest is detected, we can fallback to bundled
GoogleTest automatically.
@kou kou closed this as completed in #34920 Apr 6, 2023
kou added a commit that referenced this issue Apr 6, 2023
@kou
GH-34813: [C++] Improve GoogleTest detection (#34920)
f7644ae 
### Rationale for this change

#34765 approach has some corner cases. They causes CI failures.

### What changes are included in this PR?

If incompatible GoogleTest is detected, we can fallback to bundled GoogleTest automatically.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #34813

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 12.0.0 milestone Apr 6, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@kou @liujiacheng777
apacheGH-34813: [C++] Improve GoogleTest detection (apache#34920)
0e37cef 
### Rationale for this change

apache#34765 approach has some corner cases. They causes CI failures.

### What changes are included in this PR?

If incompatible GoogleTest is detected, we can fallback to bundled GoogleTest automatically.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#34813

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@kou @ArgusLi
apacheGH-34813: [C++] Improve GoogleTest detection (apache#34920)
a58123d 
### Rationale for this change

apache#34765 approach has some corner cases. They causes CI failures.

### What changes are included in this PR?

If incompatible GoogleTest is detected, we can fallback to bundled GoogleTest automatically.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#34813

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@kou @rtpsw
apacheGH-34813: [C++] Improve GoogleTest detection (apache#34920)
7438bc1 
### Rationale for this change

apache#34765 approach has some corner cases. They causes CI failures.

### What changes are included in this PR?

If incompatible GoogleTest is detected, we can fallback to bundled GoogleTest automatically.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#34813

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-34813: [C++] Improve GoogleTest detection kou/arrow
3 participants
@kou @westonpace @HaochengLIU