Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-34899: [C++] Dependency: bump zstd to v1.5.5 #34900

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Apr 5, 2023

Rationale for this change

Upgrade zstd from v1.5.2 to v.1.5.5

What changes are included in this PR?

zstd version upgrade

Are these changes tested?

No, waiting for ut

Are there any user-facing changes?

No

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

⚠️ GitHub issue #34899 has been automatically assigned in GitHub to PR creator.

@mapleFU
Copy link
Member Author

mapleFU commented Apr 5, 2023

CMake Warning at cmake_modules/FindLLVMAlt.cmake:58 (find_package):
  Could not find a configuration file for package "LLVM" that is compatible
  with requested version "8".

  The following configuration files were considered but not accepted:

    D:/a/_temp/msys64/clang64/lib/cmake/llvm/LLVMConfig.cmake, version: 16.0.0
    D:/a/_temp/msys64/clang64/lib/cmake/llvm/llvm-config.cmake, version: unknown

Call Stack (most recent call first):
  src/gandiva/CMakeLists.txt:28 (find_package)

Don't know that why LLVM version makes "AMD64 Windows MinGW" wrong

@mapleFU
Copy link
Member Author

mapleFU commented Apr 5, 2023

cc @kou
I've upgrade zstd to v1.5.5, however, some "AMD64 Windows MinGW", from error logs, I think it's caused by LLVM version. So no idea why them failed. Would you mind help me take a look?

@kou
Copy link
Member

kou commented Apr 5, 2023

We can handle the problem by #34768. So we can ignore it in this pull request.

@kou
Copy link
Member

kou commented Apr 5, 2023

@github-actions crossbow submit -g cpp -g wheel

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Revision: f528ece

Submitted crossbow builds: ursacomputing/crossbow @ actions-3f6787f72a

Task Status
test-alpine-linux-cpp Github Actions
test-build-cpp-fuzz Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-cuda-cpp Github Actions
test-debian-10-cpp-amd64 Github Actions
test-debian-10-cpp-i386 Github Actions
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-fedora-35-cpp Github Actions
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-20 Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-minimal-with-formats Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-22.04-cpp Github Actions
wheel-clean Github Actions
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp311-arm64 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-mojave-cp310-amd64 Github Actions
wheel-macos-mojave-cp311-amd64 Github Actions
wheel-macos-mojave-cp37-amd64 Github Actions
wheel-macos-mojave-cp38-amd64 Github Actions
wheel-macos-mojave-cp39-amd64 Github Actions
wheel-manylinux2014-cp310-amd64 Github Actions
wheel-manylinux2014-cp310-arm64 Github Actions
wheel-manylinux2014-cp311-amd64 Github Actions
wheel-manylinux2014-cp311-arm64 Github Actions
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 Github Actions
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 Github Actions
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 Github Actions
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp311-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@mapleFU
Copy link
Member Author

mapleFU commented Apr 5, 2023

oops:

https://github.com/ursacomputing/crossbow/actions/runs/4615216311/jobs/8158885302

-- Found GTest: /usr/lib/cmake/GTest/GTestConfig.cmake (found suitable version "1.11.0", minimum required is "1.10.0")  
CMake Error at cmake_modules/ThirdpartyToolchain.cmake:2237 (message):
  System GTest is built with a C++ standard lower than 17.  Use bundled GTest
  via passing in CMake flag

  -DGTest_SOURCE="BUNDLED"
Call Stack (most recent call first):
  CMakeLists.txt:505 (include)


-- Configuring incomplete, errors occurred!
See also "/build/cpp/CMakeFiles/CMakeOutput.log".
See also "/build/cpp/CMakeFiles/CMakeError.log".
1
Error: `docker-compose --file /home/runner/work/crossbow/crossbow/arrow/docker-compose.yml run --rm -e SETUPTOOLS_SCM_PRETEND_VERSION=12.0.0.dev344 alpine-linux-cpp` exited with a non-zero exit code 1, see the process log above.

@kou
Copy link
Member

kou commented Apr 5, 2023

It'll be fixed by #34869 or #34813.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit ee42b90 into apache:main Apr 5, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Apr 5, 2023
@ursabot
Copy link

ursabot commented Apr 5, 2023

Benchmark runs are scheduled for baseline = 3927a6f and contender = ee42b90. ee42b90 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️1.02% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] ee42b908 ec2-t3-xlarge-us-east-2
[Failed] ee42b908 test-mac-arm
[Finished] ee42b908 ursa-i9-9960x
[Failed] ee42b908 ursa-thinkcentre-m75q
[Finished] 3927a6f1 ec2-t3-xlarge-us-east-2
[Failed] 3927a6f1 test-mac-arm
[Finished] 3927a6f1 ursa-i9-9960x
[Failed] 3927a6f1 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Apr 5, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
### Rationale for this change

Upgrade zstd from v1.5.2 to v.1.5.5

### What changes are included in this PR?

zstd version upgrade

### Are these changes tested?

No, waiting for ut

### Are there any user-facing changes?

No

* Closes: apache#34899

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
### Rationale for this change

Upgrade zstd from v1.5.2 to v.1.5.5

### What changes are included in this PR?

zstd version upgrade

### Are these changes tested?

No, waiting for ut

### Are there any user-facing changes?

No

* Closes: apache#34899

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++] Dependency: Upgrade zstd to v1.5.5
3 participants