Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Packaging] Pin vcpkg to release that includes OpenSSL linux-headers fix #35099

Closed
sjperkins opened this issue Apr 13, 2023 · 2 comments · Fixed by #35430
Closed

[CI][Packaging] Pin vcpkg to release that includes OpenSSL linux-headers fix #35099

sjperkins opened this issue Apr 13, 2023 · 2 comments · Fixed by #35430
Assignees
@sjperkins
Labels
Component: Continuous Integration Component: Packaging Component: Release Type: enhancement
Milestone
13.0.0

Comments

@sjperkins
Copy link
Contributor

Describe the enhancement requested

Newer versions of vcpkg are required when building manylinux_2_28 arm64 platforms due to the following build issue with OpenSSL

since fixed in:

#34818 pins vcpkg to an untagged commit: see #34818 (comment), but it would be better to pin vcpkg to an official release tag.

Component(s)

Continuous Integration, Packaging, Release
@sjperkins sjperkins mentioned this issue Apr 13, 2023
Merged
sjperkins added a commit to sjperkins/arrow that referenced this issue Apr 13, 2023
@sjperkins
Comment VCPKG version with link to apache#35099
c47299c
@kou
Copy link
Member

kou commented May 3, 2023

@sjperkins It seems that a new version was released: https://github.com/microsoft/vcpkg/releases/tag/2023.04.15
Could you work on this?

@github-actions github-actions bot mentioned this issue May 4, 2023
Merged
@sjperkins
Copy link
Contributor Author

@sjperkins It seems that a new version was released: https://github.com/microsoft/vcpkg/releases/tag/2023.04.15 Could you work on this?

Opened #35430

@kou kou closed this as completed in #35430 May 6, 2023
kou pushed a commit that referenced this issue May 6, 2023
@sjperkins
GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release (#35430)
2c97151 
### Rationale for this change

- #34818 pinned vcpkg to a non-release master branch commit.
- This was to include unreleased changes, specifically microsoft/vcpkg#29674.

### What changes are included in this PR?

This pins vcpkg to the official 2023.04.15 release (commit microsoft/vcpkg@501db0f)

### Are these changes tested?

I've successfully test that the following local wheel builds succeed:

```bash
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2014
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2-28
```

### Are there any user-facing changes?

I don't believe so

* Closes: #35099

Authored-by: Simon Perkins <simon.perkins@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 13.0.0 milestone May 6, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@sjperkins @liujiacheng777
apacheGH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release (a…
ab0bb03 
…pache#35430)

### Rationale for this change

- apache#34818 pinned vcpkg to a non-release master branch commit.
- This was to include unreleased changes, specifically microsoft/vcpkg#29674.

### What changes are included in this PR?

This pins vcpkg to the official 2023.04.15 release (commit microsoft/vcpkg@501db0f)

### Are these changes tested?

I've successfully test that the following local wheel builds succeed:

```bash
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2014
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2-28
```

### Are there any user-facing changes?

I don't believe so

* Closes: apache#35099

Authored-by: Simon Perkins <simon.perkins@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@sjperkins @ArgusLi
apacheGH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release (a…
2593b49 
…pache#35430)

### Rationale for this change

- apache#34818 pinned vcpkg to a non-release master branch commit.
- This was to include unreleased changes, specifically microsoft/vcpkg#29674.

### What changes are included in this PR?

This pins vcpkg to the official 2023.04.15 release (commit microsoft/vcpkg@501db0f)

### Are these changes tested?

I've successfully test that the following local wheel builds succeed:

```bash
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2014
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2-28
```

### Are there any user-facing changes?

I don't believe so

* Closes: apache#35099

Authored-by: Simon Perkins <simon.perkins@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@sjperkins @rtpsw
apacheGH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release (a…
67cb6a4 
…pache#35430)

### Rationale for this change

- apache#34818 pinned vcpkg to a non-release master branch commit.
- This was to include unreleased changes, specifically microsoft/vcpkg#29674.

### What changes are included in this PR?

This pins vcpkg to the official 2023.04.15 release (commit microsoft/vcpkg@501db0f)

### Are these changes tested?

I've successfully test that the following local wheel builds succeed:

```bash
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2014
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2-28
```

### Are there any user-facing changes?

I don't believe so

* Closes: apache#35099

Authored-by: Simon Perkins <simon.perkins@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjperkins sjperkins

Labels
Component: Continuous Integration Component: Packaging Component: Release Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release sjperkins/arrow
2 participants
@kou @sjperkins