GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release #35430

sjperkins · 2023-05-04T08:53:42Z

Rationale for this change

GH-33804: [Python] Add support for manylinux_2_28 wheel #34818 pinned vcpkg to a non-release master branch commit.
This was to include unreleased changes, specifically [openssl] Build error with arm64-linux triplet microsoft/vcpkg#29674.

What changes are included in this PR?

This pins vcpkg to the official 2023.04.15 release (commit microsoft/vcpkg@501db0f)

Are these changes tested?

I've successfully test that the following local wheel builds succeed:

$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2014
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2-28

Are there any user-facing changes?

I don't believe so

Closes: [CI][Packaging] Pin vcpkg to release that includes OpenSSL linux-headers fix #35099

…patch

github-actions · 2023-05-04T08:54:04Z

Closes: [CI][Packaging] Pin vcpkg to release that includes OpenSSL linux-headers fix #35099

github-actions · 2023-05-04T08:54:07Z

⚠️ GitHub issue #35099 has been automatically assigned in GitHub to PR creator.

ci/vcpkg/ports.patch

.env

kou · 2023-05-04T09:21:31Z

@github-actions crossbow submit wheel-manylinux-* java-jars

github-actions · 2023-05-04T09:25:11Z

Revision: 996cd86

Submitted crossbow builds: ursacomputing/crossbow @ actions-821498ff0c

Task	Status
java-jars
wheel-manylinux-2-28-cp310-amd64
wheel-manylinux-2-28-cp310-arm64
wheel-manylinux-2-28-cp311-amd64
wheel-manylinux-2-28-cp311-arm64
wheel-manylinux-2-28-cp37-amd64
wheel-manylinux-2-28-cp37-arm64
wheel-manylinux-2-28-cp38-amd64
wheel-manylinux-2-28-cp38-arm64
wheel-manylinux-2-28-cp39-amd64
wheel-manylinux-2-28-cp39-arm64
wheel-manylinux-2014-cp310-amd64
wheel-manylinux-2014-cp310-arm64
wheel-manylinux-2014-cp311-amd64
wheel-manylinux-2014-cp311-arm64
wheel-manylinux-2014-cp37-amd64
wheel-manylinux-2014-cp37-arm64
wheel-manylinux-2014-cp38-amd64
wheel-manylinux-2014-cp38-arm64
wheel-manylinux-2014-cp39-amd64
wheel-manylinux-2014-cp39-arm64

sjperkins · 2023-05-05T06:25:49Z

All green, except for the java-jars which looks to be related to a maven timeout?

kou · 2023-05-05T06:34:38Z

I've re-ran it.

sjperkins · 2023-05-05T08:08:12Z

Failed again. On both occasions it seems related to transfer of the maven shade plugin?

Error:  Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.1.1:shade (default) on project arrow-vector: 
Execution default of goal org.apache.maven.plugins:maven-shade-plugin:3.1.1:shade failed:
Plugin org.apache.maven.plugins:maven-shade-plugin:3.1.1 or one of its dependencies could not be resolved:
Failed to collect dependencies at org.apache.maven.plugins:maven-shade-plugin:jar:3.1.1 -> org.ow2.asm:asm:jar:6.0:
Failed to read artifact descriptor for org.ow2.asm:asm:jar:6.0:
The following artifacts could not be resolved: org.ow2.asm:asm:pom:6.0 (absent):
Could not transfer artifact org.ow2.asm:asm:pom:6.0 from/to apache (https://repo.maven.apache.org/maven2/):
Connection reset -> [Help 1]

kou · 2023-05-05T20:38:55Z

Ah, the java-jars nightly builds on main were failed since 2023-05-05:

https://lists.apache.org/list.html?builds@arrow.apache.org

2023-05-04: https://github.com/ursacomputing/crossbow/actions/runs/4880720274/jobs/8715652875
2023-05-05: https://github.com/ursacomputing/crossbow/actions/runs/4891509316/jobs/8732835157

So I think that the failure isn't related to this PR.

Could you open an issue for the failure? Then we can merge this.

assignUser

+1 Thanks!

sjperkins · 2023-05-06T10:11:00Z

Could you open an issue for the failure? Then we can merge this.

#35463 opened.

kou

+1

Thanks!

ursabot · 2023-05-07T02:14:43Z

Benchmark runs are scheduled for baseline = f0e1453 and contender = 2c97151. 2c97151 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️2.22% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 2c971511 ec2-t3-xlarge-us-east-2
[Failed] 2c971511 test-mac-arm
[Finished] 2c971511 ursa-i9-9960x
[Failed] 2c971511 ursa-thinkcentre-m75q
[Finished] f0e14539 ec2-t3-xlarge-us-east-2
[Failed] f0e14539 test-mac-arm
[Finished] f0e14539 ursa-i9-9960x
[Failed] f0e14539 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ursabot · 2023-05-07T02:14:56Z

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

kou · 2023-05-07T21:04:43Z

@github-actions crossbow submit wheel-windows-*

kou · 2023-05-07T21:05:45Z

I want to check whether https://github.com/ursacomputing/crossbow/actions/runs/4906241298/jobs/8760550661#step:7:1397 is caused by this or not:

CMake Error at scripts/cmake/z_vcpkg_apply_patches.cmake:34 (message):
  Applying patch failed: error: corrupt patch at line 18

Call Stack (most recent call first):
  scripts/cmake/vcpkg_extract_source_archive.cmake:153 (z_vcpkg_apply_patches)
  scripts/cmake/vcpkg_extract_source_archive_ex.cmake:8 (vcpkg_extract_source_archive)
  scripts/cmake/vcpkg_from_github.cmake:113 (vcpkg_extract_source_archive_ex)
  ports/snappy/portfile.cmake:4 (vcpkg_from_github)
  scripts/ports.cmake:147 (include)


error: building snappy:amd64-windows-static-md-release failed with: BUILD_FAILED
Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
    https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+snappy
You can submit a new issue at:
    https://github.com/microsoft/vcpkg/issues/new?title=[snappy]+Build+error&body=Copy+issue+body+from+C%3A%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md

github-actions · 2023-05-07T21:07:14Z

Revision: 996cd86

Submitted crossbow builds: ursacomputing/crossbow @ actions-84a73cd34d

Task	Status
wheel-windows-cp310-amd64
wheel-windows-cp311-amd64
wheel-windows-cp37-amd64
wheel-windows-cp38-amd64
wheel-windows-cp39-amd64

sjperkins · 2023-05-09T07:43:20Z

wheel-windows-cp37-amd64

Looks like it may have. I've opened #35503

…pache#35430) ### Rationale for this change - apache#34818 pinned vcpkg to a non-release master branch commit. - This was to include unreleased changes, specifically microsoft/vcpkg#29674. ### What changes are included in this PR? This pins vcpkg to the official 2023.04.15 release (commit microsoft/vcpkg@501db0f) ### Are these changes tested? I've successfully test that the following local wheel builds succeed: ```bash $ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2014 $ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2-28 ``` ### Are there any user-facing changes? I don't believe so * Closes: apache#35099 Authored-by: Simon Perkins <simon.perkins@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>

sjperkins added 2 commits May 4, 2023 08:37

Upgrade vcpkg to 2023.04.15 release

e609b13

Remove non-applicable scripts/cmake/vcpkg_find_acquire_program.cmake …

4faab99

…patch

sjperkins requested review from assignUser, kou and raulcd as code owners May 4, 2023 08:53

github-actions bot added the awaiting review Awaiting review label May 4, 2023

Remove unnecessary crossbox configuration comment

996cd86

sjperkins commented May 4, 2023

View reviewed changes

ci/vcpkg/ports.patch Show resolved Hide resolved

.env Show resolved Hide resolved

github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels May 4, 2023

This was referenced May 4, 2023

GH-33804: [Python] Add support for manylinux_2_28 wheel #34818

Merged

[CI][Packaging] Pin vcpkg to release that includes OpenSSL linux-headers fix #35099

Closed

github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels May 4, 2023

assignUser approved these changes May 5, 2023

View reviewed changes

sjperkins mentioned this pull request May 6, 2023

[CI][Packacking][Java] java-jar nightly builds fail with Connect Reset related to maven-shade-plugin #35463

Closed

kou approved these changes May 6, 2023

View reviewed changes

kou merged commit 2c97151 into apache:main May 6, 2023
18 of 19 checks passed

github-actions bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels May 6, 2023

sjperkins deleted the upgrade-vcpkg branch May 7, 2023 07:01

sjperkins mentioned this pull request May 9, 2023

[CI][Packaging][C++][Windows] Snappy patch fails to apply on arm64 windows wheel builds #35503

Closed

kou mentioned this pull request Aug 14, 2023

GH-29847: [C++] Build with Azure SDK for C++ #36835

Merged

Tom-Newton mentioned this pull request Jan 15, 2024

[CI][Packaging] Upgrade vcpkg version used for release builds #39621

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release #35430

GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release #35430

sjperkins commented May 4, 2023 •

edited by github-actions bot

github-actions bot commented May 4, 2023

github-actions bot commented May 4, 2023

kou commented May 4, 2023

github-actions bot commented May 4, 2023

sjperkins commented May 5, 2023

kou commented May 5, 2023

sjperkins commented May 5, 2023

kou commented May 5, 2023

assignUser left a comment

sjperkins commented May 6, 2023

kou left a comment

ursabot commented May 7, 2023

ursabot commented May 7, 2023

kou commented May 7, 2023

kou commented May 7, 2023

github-actions bot commented May 7, 2023

sjperkins commented May 9, 2023

GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release #35430

GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release #35430

Conversation

sjperkins commented May 4, 2023 • edited by github-actions bot

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

github-actions bot commented May 4, 2023

github-actions bot commented May 4, 2023

kou commented May 4, 2023

github-actions bot commented May 4, 2023

sjperkins commented May 5, 2023

kou commented May 5, 2023

sjperkins commented May 5, 2023

kou commented May 5, 2023

assignUser left a comment

Choose a reason for hiding this comment

sjperkins commented May 6, 2023

kou left a comment

Choose a reason for hiding this comment

ursabot commented May 7, 2023

ursabot commented May 7, 2023

kou commented May 7, 2023

kou commented May 7, 2023

github-actions bot commented May 7, 2023

sjperkins commented May 9, 2023

sjperkins commented May 4, 2023 •

edited by github-actions bot