Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Two additional frames need to be skipped in Checked Allocator output #35234

Closed
hermanschaaf opened this issue Apr 19, 2023 · 0 comments · Fixed by #35231
Closed

[Go] Two additional frames need to be skipped in Checked Allocator output #35234

hermanschaaf opened this issue Apr 19, 2023 · 0 comments · Fixed by #35231
Assignees
@hermanschaaf
Labels
Component: Go Type: bug
Milestone
13.0.0

Comments

@hermanschaaf
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

When ARROW_CHECKED_MAX_RETAINED_FRAMES is set to a value greater than zero, the frames currently printed include the frame below the caller and the caller itself, which means the caller is listed twice. We should skip 2 additional frames in the Callers code as done in #35231

Component(s)

Go
@github-actions github-actions bot mentioned this issue Apr 19, 2023
Merged
@zeroshade zeroshade added this to the 13.0.0 milestone Apr 21, 2023
zeroshade pushed a commit that referenced this issue Apr 21, 2023
@hermanschaaf
GH-35234: [Go] Fix skip argument to Callers (#35231)
c48916a 
Follow-up to #35215. It's mostly cosmetic, but without the additional 2 skips passed in to `Callers`, the Caller frame is repeated in the stack trace, and one frame below it is added as well. With this change, the checked allocator stack trace contains no duplicates.

I had this change locally but didn't realize it wasn't pushed to the PR branch, sorry about that 🙇
* Closes: #35234

Authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@hermanschaaf @liujiacheng777
apacheGH-35234: [Go] Fix skip argument to Callers (apache#35231)
20c6665 
Follow-up to apache#35215. It's mostly cosmetic, but without the additional 2 skips passed in to `Callers`, the Caller frame is repeated in the stack trace, and one frame below it is added as well. With this change, the checked allocator stack trace contains no duplicates.

I had this change locally but didn't realize it wasn't pushed to the PR branch, sorry about that 🙇
* Closes: apache#35234

Authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@hermanschaaf @ArgusLi
apacheGH-35234: [Go] Fix skip argument to Callers (apache#35231)
2c26fca 
Follow-up to apache#35215. It's mostly cosmetic, but without the additional 2 skips passed in to `Callers`, the Caller frame is repeated in the stack trace, and one frame below it is added as well. With this change, the checked allocator stack trace contains no duplicates.

I had this change locally but didn't realize it wasn't pushed to the PR branch, sorry about that 🙇
* Closes: apache#35234

Authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@hermanschaaf @rtpsw
apacheGH-35234: [Go] Fix skip argument to Callers (apache#35231)
938d5ae 
Follow-up to apache#35215. It's mostly cosmetic, but without the additional 2 skips passed in to `Callers`, the Caller frame is repeated in the stack trace, and one frame below it is added as well. With this change, the checked allocator stack trace contains no duplicates.

I had this change locally but didn't realize it wasn't pushed to the PR branch, sorry about that 🙇
* Closes: apache#35234

Authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hermanschaaf hermanschaaf

Labels
Component: Go Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35234: [Go] Fix skip argument to Callers cloudquery/arrow
2 participants
@zeroshade @hermanschaaf