GH-35212: [Go] Add ability to show full call stack with ARROW_CHECKED_MAX_RETAINED_FRAMES #35215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
changed the title
|
|
zeroshade
approved these changes
Apr 18, 2023
github-actions
bot
added
awaiting merge
|
Benchmark runs are scheduled for baseline = 16bd95f and contender = 7a7b414. 7a7b414 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
zeroshade
pushed a commit
that referenced
this pull request
Apr 21, 2023
Follow-up to #35215. It's mostly cosmetic, but without the additional 2 skips passed in to `Callers`, the Caller frame is repeated in the stack trace, and one frame below it is added as well. With this change, the checked allocator stack trace contains no duplicates. I had this change locally but didn't realize it wasn't pushed to the PR branch, sorry about that 🙇 * Closes: #35234 Authored-by: Herman Schaaf <hermanschaaf@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this pull request
May 11, 2023
…HECKED_MAX_RETAINED_FRAMES (apache#35215) This adds support for printing the full call stack when a leak is reported by the checked memory allocator. An `ARROW_CHECKED_MAX_RETAINED_FRAMES` environment variable controls how many frames are retained. To keep this completely backwards-compatible, the default right now is zero. In this case, the reported error is exactly the same as before. When a higher value is given though, a longer call stack is printed. For example: Before (same as `ARROW_CHECKED_MAX_RETAINED_FRAMES=0`): ``` checked_allocator.go:160: LEAK of 64 bytes FROM github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).newData line 2396 ``` After (with `ARROW_CHECKED_MAX_RETAINED_FRAMES=100`): ``` checked_allocator.go:160: LEAK of 64 bytes FROM github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).newData line 2396 github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).NewTimestampArray line 2386 github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).NewArray line 2380 github.com/apache/arrow/go/v12/arrow/array.(*RecordBuilder).NewRecord line 346 github.com/cloudquery/plugin-sdk/v2/testdata.GenTestData line 243 github.com/cloudquery/plugin-sdk/v2/plugins/destination.testMigration line 53 github.com/cloudquery/plugin-sdk/v2/plugins/destination.(*PluginTestSuite).destinationPluginTestMigrate.func5 line 239 testing.tRunner line 1576 runtime.goexit line 1172 ``` * Closes: apache#35212 Authored-by: Herman Schaaf <hermanschaaf@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this pull request
May 11, 2023
Follow-up to apache#35215. It's mostly cosmetic, but without the additional 2 skips passed in to `Callers`, the Caller frame is repeated in the stack trace, and one frame below it is added as well. With this change, the checked allocator stack trace contains no duplicates. I had this change locally but didn't realize it wasn't pushed to the PR branch, sorry about that 🙇 * Closes: apache#35234 Authored-by: Herman Schaaf <hermanschaaf@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
…HECKED_MAX_RETAINED_FRAMES (apache#35215) This adds support for printing the full call stack when a leak is reported by the checked memory allocator. An `ARROW_CHECKED_MAX_RETAINED_FRAMES` environment variable controls how many frames are retained. To keep this completely backwards-compatible, the default right now is zero. In this case, the reported error is exactly the same as before. When a higher value is given though, a longer call stack is printed. For example: Before (same as `ARROW_CHECKED_MAX_RETAINED_FRAMES=0`): ``` checked_allocator.go:160: LEAK of 64 bytes FROM github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).newData line 2396 ``` After (with `ARROW_CHECKED_MAX_RETAINED_FRAMES=100`): ``` checked_allocator.go:160: LEAK of 64 bytes FROM github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).newData line 2396 github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).NewTimestampArray line 2386 github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).NewArray line 2380 github.com/apache/arrow/go/v12/arrow/array.(*RecordBuilder).NewRecord line 346 github.com/cloudquery/plugin-sdk/v2/testdata.GenTestData line 243 github.com/cloudquery/plugin-sdk/v2/plugins/destination.testMigration line 53 github.com/cloudquery/plugin-sdk/v2/plugins/destination.(*PluginTestSuite).destinationPluginTestMigrate.func5 line 239 testing.tRunner line 1576 runtime.goexit line 1172 ``` * Closes: apache#35212 Authored-by: Herman Schaaf <hermanschaaf@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
Follow-up to apache#35215. It's mostly cosmetic, but without the additional 2 skips passed in to `Callers`, the Caller frame is repeated in the stack trace, and one frame below it is added as well. With this change, the checked allocator stack trace contains no duplicates. I had this change locally but didn't realize it wasn't pushed to the PR branch, sorry about that 🙇 * Closes: apache#35234 Authored-by: Herman Schaaf <hermanschaaf@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this pull request
May 16, 2023
…HECKED_MAX_RETAINED_FRAMES (apache#35215) This adds support for printing the full call stack when a leak is reported by the checked memory allocator. An `ARROW_CHECKED_MAX_RETAINED_FRAMES` environment variable controls how many frames are retained. To keep this completely backwards-compatible, the default right now is zero. In this case, the reported error is exactly the same as before. When a higher value is given though, a longer call stack is printed. For example: Before (same as `ARROW_CHECKED_MAX_RETAINED_FRAMES=0`): ``` checked_allocator.go:160: LEAK of 64 bytes FROM github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).newData line 2396 ``` After (with `ARROW_CHECKED_MAX_RETAINED_FRAMES=100`): ``` checked_allocator.go:160: LEAK of 64 bytes FROM github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).newData line 2396 github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).NewTimestampArray line 2386 github.com/apache/arrow/go/v12/arrow/array.(*TimestampBuilder).NewArray line 2380 github.com/apache/arrow/go/v12/arrow/array.(*RecordBuilder).NewRecord line 346 github.com/cloudquery/plugin-sdk/v2/testdata.GenTestData line 243 github.com/cloudquery/plugin-sdk/v2/plugins/destination.testMigration line 53 github.com/cloudquery/plugin-sdk/v2/plugins/destination.(*PluginTestSuite).destinationPluginTestMigrate.func5 line 239 testing.tRunner line 1576 runtime.goexit line 1172 ``` * Closes: apache#35212 Authored-by: Herman Schaaf <hermanschaaf@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this pull request
May 16, 2023
Follow-up to apache#35215. It's mostly cosmetic, but without the additional 2 skips passed in to `Callers`, the Caller frame is repeated in the stack trace, and one frame below it is added as well. With this change, the checked allocator stack trace contains no duplicates. I had this change locally but didn't realize it wasn't pushed to the PR branch, sorry about that 🙇 * Closes: apache#35234 Authored-by: Herman Schaaf <hermanschaaf@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
kou
pushed a commit
to apache/arrow-go
that referenced
this pull request
Aug 30, 2024
Follow-up to apache/arrow#35215. It's mostly cosmetic, but without the additional 2 skips passed in to `Callers`, the Caller frame is repeated in the stack trace, and one frame below it is added as well. With this change, the checked allocator stack trace contains no duplicates. I had this change locally but didn't realize it wasn't pushed to the PR branch, sorry about that 🙇 * Closes: #35234 Authored-by: Herman Schaaf <hermanschaaf@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for printing the full call stack when a leak is reported by the checked memory allocator. An
ARROW_CHECKED_MAX_RETAINED_FRAMESenvironment variable controls how many frames are retained. To keep this completely backwards-compatible, the default right now is zero. In this case, the reported error is exactly the same as before. When a higher value is given though, a longer call stack is printed. For example:Before (same as
ARROW_CHECKED_MAX_RETAINED_FRAMES=0):After (with
ARROW_CHECKED_MAX_RETAINED_FRAMES=100):