Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Website][Docs] Missing logo on Arrow docs page #35406

Closed
raulcd opened this issue May 3, 2023 · 4 comments · Fixed by #35405
Closed

[Website][Docs] Missing logo on Arrow docs page #35406

raulcd opened this issue May 3, 2023 · 4 comments · Fixed by #35405
Assignees
@jorisvandenbossche
Labels
Component: Documentation Component: Website good-first-issue Type: bug
Milestone
13.0.0

Comments

@raulcd
Copy link
Member

raulcd commented May 3, 2023

Describe the bug, including details regarding any error messages, version, and platform.

There seems to be a missing logo from the generated docs:
https://arrow.apache.org/docs/
image
The logo is visible on other pages, like:
https://arrow.apache.org/docs/format/Versioning.html
image

Component(s)

Documentation, Website
@raulcd
Copy link
Member Author

raulcd commented May 3, 2023

@jorisvandenbossche , I've just seen you just opened something that might be related (sphinx 6). Should we close this one?

@jorisvandenbossche
Copy link
Member

Let's wait a moment to see if the preview of #35405 actually fixes it (I am not fully sure if the missing logo is also caused by the sphinx version)

@jorisvandenbossche
Copy link
Member

This was actually caused by #35194. Given that was needed to support sphinx 6.x (and I am pinning to 5 to fix the other issues), I will also temporarily revert that patch.

@jorisvandenbossche
Copy link
Member

Actually not reverting, just fixing so it works for both sphinx 5 and 6

@jorisvandenbossche jorisvandenbossche mentioned this issue May 3, 2023
Merged
@jorisvandenbossche jorisvandenbossche self-assigned this May 3, 2023
jorisvandenbossche added a commit that referenced this issue May 4, 2023
@jorisvandenbossche
GH-35404: [Docs] Fix logo url and temporarily pin sphinx to 5.x to (#…
57c956e 
…35405)

See #35403 about requiring some fixes on our side to support sphinx 6. Until then, let's pin sphinx to <6.

* Closes: #35404
* Closes: #35406

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche added this to the 13.0.0 milestone May 4, 2023
raulcd pushed a commit that referenced this issue May 5, 2023
@jorisvandenbossche @raulcd
GH-35404: [Docs] Fix logo url and temporarily pin sphinx to 5.x to (#…
fab79f5 
…35405)

See #35403 about requiring some fixes on our side to support sphinx 6. Until then, let's pin sphinx to <6.

* Closes: #35404
* Closes: #35406

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@jorisvandenbossche @liujiacheng777
apacheGH-35404: [Docs] Fix logo url and temporarily pin sphinx to 5.x…
7e122c6 
… to (apache#35405)

See apache#35403 about requiring some fixes on our side to support sphinx 6. Until then, let's pin sphinx to <6.

* Closes: apache#35404
* Closes: apache#35406

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@jorisvandenbossche @ArgusLi
apacheGH-35404: [Docs] Fix logo url and temporarily pin sphinx to 5.x…
8fe8217 
… to (apache#35405)

See apache#35403 about requiring some fixes on our side to support sphinx 6. Until then, let's pin sphinx to <6.

* Closes: apache#35404
* Closes: apache#35406

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@jorisvandenbossche @rtpsw
apacheGH-35404: [Docs] Fix logo url and temporarily pin sphinx to 5.x…
efebbc4 
… to (apache#35405)

See apache#35403 about requiring some fixes on our side to support sphinx 6. Until then, let's pin sphinx to <6.

* Closes: apache#35404
* Closes: apache#35406

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
raulcd pushed a commit that referenced this issue May 30, 2023
@jorisvandenbossche @raulcd
GH-35404: [Docs] Fix logo url and temporarily pin sphinx to 5.x to (#…
59f546c 
…35405)

See #35403 about requiring some fixes on our side to support sphinx 6. Until then, let's pin sphinx to <6.

* Closes: #35404
* Closes: #35406

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorisvandenbossche jorisvandenbossche

Labels
Component: Documentation Component: Website good-first-issue Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35404: [Docs] Fix logo url and temporarily pin sphinx to 5.x to jorisvandenbossche/arrow
2 participants
@raulcd @jorisvandenbossche