GH-35192: [Docs] Switch from logo to logo_url to support sphinx >= 6
#35194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Documentation
awaiting committer review
|
@github-actions crossbow submit preview-docs |
|
Revision: c08d94a Submitted crossbow builds: ursacomputing/crossbow @ actions-a255490ddc
|
|
@github-actions crossbow submit test-ubuntu-default-docs |
|
Revision: c08d94a Submitted crossbow builds: ursacomputing/crossbow @ actions-6dd0e5c7ff
|
github-actions
bot
added
awaiting merge
|
Validated that it works on the preview docs here: http://crossbow.voltrondata.com/pr_docs/35204/c_glib/index.html |
assignUser
pushed a commit
that referenced
this pull request
Apr 18, 2023
…ster (#35204) ### Rationale for this change The job is failing with: ``` Fetching the repository /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/master*:refs/remotes/origin/master* +refs/tags/master*:refs/tags/master* The process '/usr/bin/git' failed with exit code 1 ``` See: #35194 (comment) ### What changes are included in this PR? Change `master` for `main` on the job. ### Are these changes tested? Archery test Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
raulcd
pushed a commit
that referenced
this pull request
Apr 19, 2023
…= 6 (#35194) ### Rationale for this change Sphinx dropped support for the `logo` property in release 6. See sphinx-doc/sphinx#11062 Instead we are supposed to use `logo_url` which has been available since release 4. ### What changes are included in this PR? Change from `logo` to `logo_url` ### Are these changes tested? There was a CI test that was failing so yes. ### Are there any user-facing changes? No. We already required `sphinx >= 4` and since `logo_url` is available in 4 we should not need to update the minimum sphinx version. * Closes: #35192 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
|
Benchmark runs are scheduled for baseline = 1deb740 and contender = 00072f9. 00072f9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this pull request
May 11, 2023
…hinx >= 6 (apache#35194) ### Rationale for this change Sphinx dropped support for the `logo` property in release 6. See sphinx-doc/sphinx#11062 Instead we are supposed to use `logo_url` which has been available since release 4. ### What changes are included in this PR? Change from `logo` to `logo_url` ### Are these changes tested? There was a CI test that was failing so yes. ### Are there any user-facing changes? No. We already required `sphinx >= 4` and since `logo_url` is available in 4 we should not need to update the minimum sphinx version. * Closes: apache#35192 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this pull request
May 11, 2023
…ster (apache#35204) ### Rationale for this change The job is failing with: ``` Fetching the repository /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/master*:refs/remotes/origin/master* +refs/tags/master*:refs/tags/master* The process '/usr/bin/git' failed with exit code 1 ``` See: apache#35194 (comment) ### What changes are included in this PR? Change `master` for `main` on the job. ### Are these changes tested? Archery test Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
…hinx >= 6 (apache#35194) ### Rationale for this change Sphinx dropped support for the `logo` property in release 6. See sphinx-doc/sphinx#11062 Instead we are supposed to use `logo_url` which has been available since release 4. ### What changes are included in this PR? Change from `logo` to `logo_url` ### Are these changes tested? There was a CI test that was failing so yes. ### Are there any user-facing changes? No. We already required `sphinx >= 4` and since `logo_url` is available in 4 we should not need to update the minimum sphinx version. * Closes: apache#35192 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
…ster (apache#35204) ### Rationale for this change The job is failing with: ``` Fetching the repository /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/master*:refs/remotes/origin/master* +refs/tags/master*:refs/tags/master* The process '/usr/bin/git' failed with exit code 1 ``` See: apache#35194 (comment) ### What changes are included in this PR? Change `master` for `main` on the job. ### Are these changes tested? Archery test Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this pull request
May 16, 2023
…hinx >= 6 (apache#35194) ### Rationale for this change Sphinx dropped support for the `logo` property in release 6. See sphinx-doc/sphinx#11062 Instead we are supposed to use `logo_url` which has been available since release 4. ### What changes are included in this PR? Change from `logo` to `logo_url` ### Are these changes tested? There was a CI test that was failing so yes. ### Are there any user-facing changes? No. We already required `sphinx >= 4` and since `logo_url` is available in 4 we should not need to update the minimum sphinx version. * Closes: apache#35192 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this pull request
May 16, 2023
…ster (apache#35204) ### Rationale for this change The job is failing with: ``` Fetching the repository /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/master*:refs/remotes/origin/master* +refs/tags/master*:refs/tags/master* The process '/usr/bin/git' failed with exit code 1 ``` See: apache#35194 (comment) ### What changes are included in this PR? Change `master` for `main` on the job. ### Are these changes tested? Archery test Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Sphinx dropped support for the
logoproperty in release 6. See sphinx-doc/sphinx#11062 Instead we are supposed to uselogo_urlwhich has been available since release 4.What changes are included in this PR?
Change from
logotologo_urlAre these changes tested?
There was a CI test that was failing so yes.
Are there any user-facing changes?
No. We already required
sphinx >= 4and sincelogo_urlis available in 4 we should not need to update the minimum sphinx version.