Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MATLAB] Add CMake build directory to MATLAB .gitignore #35489

Closed
kevingurney opened this issue May 8, 2023 · 1 comment · Fixed by #35493
Closed

[MATLAB] Add CMake build directory to MATLAB .gitignore #35489

kevingurney opened this issue May 8, 2023 · 1 comment · Fixed by #35493
Assignees
@kevingurney
Labels
Component: MATLAB Type: enhancement
Milestone
13.0.0

Comments

@kevingurney
Copy link
Member

Describe the enhancement requested

A typical name that is used for the build folder when building CMake projects is build.

The documentation for building the MATLAB interface mentions using build as the build directory name. It would be helpful if build/ was added to the MATLAB interface .gitignore so that the build directory doesn't show up in the list of untracked files with git.

Component(s)

MATLAB
@kevingurney
Copy link
Member Author

take

@github-actions github-actions bot mentioned this issue May 8, 2023
Merged
@kevingurney kevingurney changed the title [MATLAB] Add build directory to MATLAB .gitignore [MATLAB] Add CMake build directory to MATLAB .gitignore May 8, 2023
@kou kou closed this as completed in #35493 May 8, 2023
kou pushed a commit that referenced this issue May 8, 2023
@kevingurney
GH-35489: [MATLAB] Add CMake build directory to MATLAB .gitignore (…
ad43544 
…#35493)

### Rationale for this change

A typical name that is used for the build folder when building CMake projects is `build`.

The documentation for building the MATLAB interface [mentions using `build` as the build directory name](https://github.com/apache/arrow/tree/main/matlab#build). It would be helpful if `build/` was added to the MATLAB interface `.gitignore` so that the build directory doesn't show up in the list of untracked files with `git`.

### What changes are included in this PR?

Added `build` to the MATLAB `.gitignore`.

### Are these changes tested?

Manually verified on Debian 11 that the `build` folder doesn't show up as untracked with `git`.

### Are there any user-facing changes?

No.
* Closes: #35489

Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 13.0.0 milestone May 9, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@kevingurney @liujiacheng777
apacheGH-35489: [MATLAB] Add CMake build directory to MATLAB `.giti…
291225f 
…gnore` (apache#35493)

### Rationale for this change

A typical name that is used for the build folder when building CMake projects is `build`.

The documentation for building the MATLAB interface [mentions using `build` as the build directory name](https://github.com/apache/arrow/tree/main/matlab#build). It would be helpful if `build/` was added to the MATLAB interface `.gitignore` so that the build directory doesn't show up in the list of untracked files with `git`.

### What changes are included in this PR?

Added `build` to the MATLAB `.gitignore`.

### Are these changes tested?

Manually verified on Debian 11 that the `build` folder doesn't show up as untracked with `git`.

### Are there any user-facing changes?

No.
* Closes: apache#35489

Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@kevingurney @ArgusLi
apacheGH-35489: [MATLAB] Add CMake build directory to MATLAB `.giti…
6f67cc8 
…gnore` (apache#35493)

### Rationale for this change

A typical name that is used for the build folder when building CMake projects is `build`.

The documentation for building the MATLAB interface [mentions using `build` as the build directory name](https://github.com/apache/arrow/tree/main/matlab#build). It would be helpful if `build/` was added to the MATLAB interface `.gitignore` so that the build directory doesn't show up in the list of untracked files with `git`.

### What changes are included in this PR?

Added `build` to the MATLAB `.gitignore`.

### Are these changes tested?

Manually verified on Debian 11 that the `build` folder doesn't show up as untracked with `git`.

### Are there any user-facing changes?

No.
* Closes: apache#35489

Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@kevingurney @rtpsw
apacheGH-35489: [MATLAB] Add CMake build directory to MATLAB `.giti…
cd75f25 
…gnore` (apache#35493)

### Rationale for this change

A typical name that is used for the build folder when building CMake projects is `build`.

The documentation for building the MATLAB interface [mentions using `build` as the build directory name](https://github.com/apache/arrow/tree/main/matlab#build). It would be helpful if `build/` was added to the MATLAB interface `.gitignore` so that the build directory doesn't show up in the list of untracked files with `git`.

### What changes are included in this PR?

Added `build` to the MATLAB `.gitignore`.

### Are these changes tested?

Manually verified on Debian 11 that the `build` folder doesn't show up as untracked with `git`.

### Are there any user-facing changes?

No.
* Closes: apache#35489

Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevingurney kevingurney

Labels
Component: MATLAB Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35489: [MATLAB] Add CMake build directory to MATLAB .gitignore mathworks/arrow
2 participants
@kou @kevingurney