-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-35489: [MATLAB] Add CMake build
directory to MATLAB .gitignore
#35493
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
.gitignore
build
directory to MATLAB .gitignore
build
directory to MATLAB .gitignore
build
directory to MATLAB .gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Benchmark runs are scheduled for baseline = 5b8eb64 and contender = ad43544. ad43544 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
…gnore` (apache#35493) ### Rationale for this change A typical name that is used for the build folder when building CMake projects is `build`. The documentation for building the MATLAB interface [mentions using `build` as the build directory name](https://github.com/apache/arrow/tree/main/matlab#build). It would be helpful if `build/` was added to the MATLAB interface `.gitignore` so that the build directory doesn't show up in the list of untracked files with `git`. ### What changes are included in this PR? Added `build` to the MATLAB `.gitignore`. ### Are these changes tested? Manually verified on Debian 11 that the `build` folder doesn't show up as untracked with `git`. ### Are there any user-facing changes? No. * Closes: apache#35489 Authored-by: Kevin Gurney <kgurney@mathworks.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…gnore` (apache#35493) ### Rationale for this change A typical name that is used for the build folder when building CMake projects is `build`. The documentation for building the MATLAB interface [mentions using `build` as the build directory name](https://github.com/apache/arrow/tree/main/matlab#build). It would be helpful if `build/` was added to the MATLAB interface `.gitignore` so that the build directory doesn't show up in the list of untracked files with `git`. ### What changes are included in this PR? Added `build` to the MATLAB `.gitignore`. ### Are these changes tested? Manually verified on Debian 11 that the `build` folder doesn't show up as untracked with `git`. ### Are there any user-facing changes? No. * Closes: apache#35489 Authored-by: Kevin Gurney <kgurney@mathworks.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…gnore` (apache#35493) ### Rationale for this change A typical name that is used for the build folder when building CMake projects is `build`. The documentation for building the MATLAB interface [mentions using `build` as the build directory name](https://github.com/apache/arrow/tree/main/matlab#build). It would be helpful if `build/` was added to the MATLAB interface `.gitignore` so that the build directory doesn't show up in the list of untracked files with `git`. ### What changes are included in this PR? Added `build` to the MATLAB `.gitignore`. ### Are these changes tested? Manually verified on Debian 11 that the `build` folder doesn't show up as untracked with `git`. ### Are there any user-facing changes? No. * Closes: apache#35489 Authored-by: Kevin Gurney <kgurney@mathworks.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
A typical name that is used for the build folder when building CMake projects is
build
.The documentation for building the MATLAB interface mentions using
build
as the build directory name. It would be helpful ifbuild/
was added to the MATLAB interface.gitignore
so that the build directory doesn't show up in the list of untracked files withgit
.What changes are included in this PR?
Added
build
to the MATLAB.gitignore
.Are these changes tested?
Manually verified on Debian 11 that the
build
folder doesn't show up as untracked withgit
.Are there any user-facing changes?
No.
build
directory to MATLAB.gitignore
#35489