Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35489: [MATLAB] Add CMake build directory to MATLAB .gitignore #35493

Merged
merged 1 commit into from
May 8, 2023

Conversation

kevingurney
Copy link
Member

@kevingurney kevingurney commented May 8, 2023

Rationale for this change

A typical name that is used for the build folder when building CMake projects is build.

The documentation for building the MATLAB interface mentions using build as the build directory name. It would be helpful if build/ was added to the MATLAB interface .gitignore so that the build directory doesn't show up in the list of untracked files with git.

What changes are included in this PR?

Added build to the MATLAB .gitignore.

Are these changes tested?

Manually verified on Debian 11 that the build folder doesn't show up as untracked with git.

Are there any user-facing changes?

No.

@github-actions
Copy link

github-actions bot commented May 8, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@kevingurney kevingurney changed the title [MATLAB] Add CMake build folder to MATLAB .gitignore GH-35489: [MATLAB] Add build directory to MATLAB .gitignore May 8, 2023
@github-actions github-actions bot added the awaiting review Awaiting review label May 8, 2023
@github-actions
Copy link

github-actions bot commented May 8, 2023

@kevingurney kevingurney changed the title GH-35489: [MATLAB] Add build directory to MATLAB .gitignore GH-35489: [MATLAB] Add CMake build directory to MATLAB .gitignore May 8, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit ad43544 into apache:main May 8, 2023
10 checks passed
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 8, 2023
@ursabot
Copy link

ursabot commented May 9, 2023

Benchmark runs are scheduled for baseline = 5b8eb64 and contender = ad43544. ad43544 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️2.22% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️2.86% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] ad43544e ec2-t3-xlarge-us-east-2
[Failed] ad43544e test-mac-arm
[Finished] ad43544e ursa-i9-9960x
[Failed] ad43544e ursa-thinkcentre-m75q
[Finished] 5b8eb647 ec2-t3-xlarge-us-east-2
[Failed] 5b8eb647 test-mac-arm
[Finished] 5b8eb647 ursa-i9-9960x
[Failed] 5b8eb647 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 9, 2023

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

@kevingurney kevingurney deleted the GH-35489 branch May 9, 2023 12:50
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
…gnore` (apache#35493)

### Rationale for this change

A typical name that is used for the build folder when building CMake projects is `build`.

The documentation for building the MATLAB interface [mentions using `build` as the build directory name](https://github.com/apache/arrow/tree/main/matlab#build). It would be helpful if `build/` was added to the MATLAB interface `.gitignore` so that the build directory doesn't show up in the list of untracked files with `git`.

### What changes are included in this PR?

Added `build` to the MATLAB `.gitignore`.

### Are these changes tested?

Manually verified on Debian 11 that the `build` folder doesn't show up as untracked with `git`.

### Are there any user-facing changes?

No.
* Closes: apache#35489

Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
…gnore` (apache#35493)

### Rationale for this change

A typical name that is used for the build folder when building CMake projects is `build`.

The documentation for building the MATLAB interface [mentions using `build` as the build directory name](https://github.com/apache/arrow/tree/main/matlab#build). It would be helpful if `build/` was added to the MATLAB interface `.gitignore` so that the build directory doesn't show up in the list of untracked files with `git`.

### What changes are included in this PR?

Added `build` to the MATLAB `.gitignore`.

### Are these changes tested?

Manually verified on Debian 11 that the `build` folder doesn't show up as untracked with `git`.

### Are there any user-facing changes?

No.
* Closes: apache#35489

Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
…gnore` (apache#35493)

### Rationale for this change

A typical name that is used for the build folder when building CMake projects is `build`.

The documentation for building the MATLAB interface [mentions using `build` as the build directory name](https://github.com/apache/arrow/tree/main/matlab#build). It would be helpful if `build/` was added to the MATLAB interface `.gitignore` so that the build directory doesn't show up in the list of untracked files with `git`.

### What changes are included in this PR?

Added `build` to the MATLAB `.gitignore`.

### Are these changes tested?

Manually verified on Debian 11 that the `build` folder doesn't show up as untracked with `git`.

### Are there any user-facing changes?

No.
* Closes: apache#35489

Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MATLAB] Add CMake build directory to MATLAB .gitignore
3 participants