[Java]bugfix: RangeEqualsVisitor compare BitVector false when compared vectors have different begin index. #35528
Comments
wenxlan
changed the title
lidavidm
pushed a commit
that referenced
this issue
May 12, 2023
…rent begin index (#35525) ### Rationale for this change bugfix: RangeEqualsVisitor compare BitVector false when compared vectors have different begin index. In origin code, when compared vectors have different begin index, it will compare vectors value with same index, which is error logic. this pr is to fix it. ### What changes are included in this PR? only changes RangeEqualsVisitor.compareBaseFixedWidthVectors method, and add test ### Are these changes tested? yes. ### Are there any user-facing changes? no. * Closes: #35528 Authored-by: wenxianglan.233 <wenxianglan.233@bytedance.com> Signed-off-by: David Li <li.davidm96@gmail.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
… different begin index (apache#35525) ### Rationale for this change bugfix: RangeEqualsVisitor compare BitVector false when compared vectors have different begin index. In origin code, when compared vectors have different begin index, it will compare vectors value with same index, which is error logic. this pr is to fix it. ### What changes are included in this PR? only changes RangeEqualsVisitor.compareBaseFixedWidthVectors method, and add test ### Are these changes tested? yes. ### Are there any user-facing changes? no. * Closes: apache#35528 Authored-by: wenxianglan.233 <wenxianglan.233@bytedance.com> Signed-off-by: David Li <li.davidm96@gmail.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
… different begin index (apache#35525) ### Rationale for this change bugfix: RangeEqualsVisitor compare BitVector false when compared vectors have different begin index. In origin code, when compared vectors have different begin index, it will compare vectors value with same index, which is error logic. this pr is to fix it. ### What changes are included in this PR? only changes RangeEqualsVisitor.compareBaseFixedWidthVectors method, and add test ### Are these changes tested? yes. ### Are there any user-facing changes? no. * Closes: apache#35528 Authored-by: wenxianglan.233 <wenxianglan.233@bytedance.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
In origin code, when compared vectors have different begin index, it will compare vectors value with same index, which is error logic. this pr is to fix it.
Component(s)
Java
The text was updated successfully, but these errors were encountered: