Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][C++][MinGW] Scalar cast tests are crashed #35662

Closed
kou opened this issue May 18, 2023 · 0 comments · Fixed by #35663
Closed

[CI][C++][MinGW] Scalar cast tests are crashed #35662

kou opened this issue May 18, 2023 · 0 comments · Fixed by #35663
Assignees
@kou
Labels
Component: C++ Component: Continuous Integration Type: bug
Milestone
13.0.0

Comments

@kou
Copy link
Member

kou commented May 18, 2023

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/apache/arrow/actions/runs/5007948386/jobs/8975224419

The following tests FAILED:
	  6 - arrow-scalar-test (SEGFAULT)
	 19 - arrow-compute-scalar-cast-test (SEGFAULT)
	 25 - arrow-compute-vector-test (SEGFAULT)
	 26 - arrow-compute-aggregate-test (SEGFAULT)

Component(s)

C++, Continuous Integration
@kou kou added the Type: bug label May 18, 2023
kou added a commit to kou/arrow that referenced this issue May 18, 2023
@kou
apacheGH-35662: [CI][C++][MinGW] Reduce needless template usages
c34fc75 
I don't know why but this can avoid SEGV with MinGW.
@github-actions github-actions bot mentioned this issue May 18, 2023
Merged
kou added a commit to kou/arrow that referenced this issue May 18, 2023
@kou
apacheGH-35662: [CI][C++][MinGW] Reduce needless template usages
8d875eb 
I don't know why but this can avoid SEGV with MinGW.
kou added a commit to kou/arrow that referenced this issue May 18, 2023
@kou
apacheGH-35662: [CI][C++][MinGW] Reduce needless template usages
7ab0aa9 
I don't know why but this can avoid SEGV with MinGW.
@pitrou pitrou added this to the 13.0.0 milestone May 19, 2023
pitrou pushed a commit that referenced this issue May 19, 2023
@kou
GH-35662: [CI][C++][MinGW] Avoid crash in FormatTwoDigits() with rele…
61447d9 
…ase build (#35663)

### Rationale for this change

I don't know why but the following combination is crashed:

* Template `FormatTwoDigits()` implementation without explicit `inline`
* MinGW
* Release build

### What changes are included in this PR?

This breaks the "template `FormatTwoDigits()` implementation without explicit `inline`" by specifying `inline` explicitly.

But I don't know why we can avoid this crash by specifying `inline` explicitly...

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #35662

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Component: Continuous Integration Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35662: [CI][C++][MinGW] Avoid crash in FormatTwoDigits() with release build kou/arrow
2 participants
@kou @pitrou