-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][C++] arrow-array-test slow on macOS #35712
Comments
Hi, pitrou, on My MacOS with M1 Pro, test runs much more faster, here are some slow ones:
The whole tests are finished within 15secs... So maybe we can print the result in CI? The tests are runed in DEBUG mode, CMAKE configs are:
|
Perhaps you can submit a draft PR to run the tests in verbose mode indeed. |
I'm glad to but it's a bit late in my timezone, if nobody tries it tonight, I'll have a try in the morning :-) |
Hi pitrou, I've tried it here: https://github.com/apache/arrow/actions/runs/5053338938/jobs/9067090574?pr=35719
Seems that we should optimize |
Definitely! |
The test is here: #35719 |
Also cc @felipecrv |
I guess I've found out the reason. Maybe it's ASSERT_DEATH(
{
std::shared_ptr<Array> null_dict_arr =
std::make_shared<DictionaryArray>(dict_type, indices, nullptr);
},
""); In |
After remove ASSERT_DEATH:
|
Can you validate on the macOS CI? |
Thanks for the investigation @mapleFU ! I think we can just disable the death test on macOS, since other platforms don't seem to have that problem. |
Okay, let me submit a quick fixing with a new patch |
…35724) ### Rationale for this change Disable ASSERT_DEATH in MacOS. According to #35712, it would making CI extremely slow. ### What changes are included in this PR? Disable test in macos ### Are these changes tested? no ### Are there any user-facing changes? no * Closes: #35712 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Describe the bug, including details regarding any error messages, version, and platform.
This is rather minor, but
arrow-array-test
takes more than one minute on our C++ macOS CI. I even saw it sporadically time out.It would be nice to find out the cause, as it may be an underlying performance problem in Arrow C++.
Component(s)
C++
The text was updated successfully, but these errors were encountered: