-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++][CI] EnsureAlignment.Buffer fails on test-build-vcpkg-win #35820
Labels
Milestone
Comments
The error seems to be on the alignment itself:
cc @westonpace |
pitrou
pushed a commit
that referenced
this issue
May 31, 2023
…win (#35834) ### Rationale for this change There is a bug in the version of mimalloc that we currently vendor (2.0.6) which is microsoft/mimalloc#700 This bug causes aligned allocations to be improperly aligned if the requested alignment is greater than 128 and less than 1024. The allocations are always given 128 byte alignment. This also only seems to affect release mode. In practice, we never actually request alignment greater than 128 bytes. However, there was a test case that was requesting alignment of 256 bytes. Since this bug only affects a test case I'm not sure it warrants upgrading the mimalloc version (though we might want to do so at some point for other reasons). One could argue that memory pool is a part of our public interface and so this is a bug in a public method (the ability to allocate an aligned buffer) though users are welcome to use a newer version of mimalloc on their own. ### What changes are included in this PR? The test is modified to request 128 byte alignment instead of 256 byte alignment ### Are these changes tested? I was able to reproduce the issue on my Linux system by compiling in release mode and using mimalloc. I verified that upgrading mimalloc to 2.1.0 prevented the bug. The fix itself is a test case and so the change is tested. ### Are there any user-facing changes? No. * Closes: #35820 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd
pushed a commit
that referenced
this issue
May 31, 2023
…win (#35834) ### Rationale for this change There is a bug in the version of mimalloc that we currently vendor (2.0.6) which is microsoft/mimalloc#700 This bug causes aligned allocations to be improperly aligned if the requested alignment is greater than 128 and less than 1024. The allocations are always given 128 byte alignment. This also only seems to affect release mode. In practice, we never actually request alignment greater than 128 bytes. However, there was a test case that was requesting alignment of 256 bytes. Since this bug only affects a test case I'm not sure it warrants upgrading the mimalloc version (though we might want to do so at some point for other reasons). One could argue that memory pool is a part of our public interface and so this is a bug in a public method (the ability to allocate an aligned buffer) though users are welcome to use a newer version of mimalloc on their own. ### What changes are included in this PR? The test is modified to request 128 byte alignment instead of 256 byte alignment ### Are these changes tested? I was able to reproduce the issue on my Linux system by compiling in release mode and using mimalloc. I verified that upgrading mimalloc to 2.1.0 prevented the bug. The fix itself is a test case and so the change is tested. ### Are there any user-facing changes? No. * Closes: #35820 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
Since #35565 was merged and
EnsureAlignment.Buffer
was added the job test-build-vcpkg-win has been failing with:Component(s)
C++, Continuous Integration
The text was updated successfully, but these errors were encountered: