Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Benchmark reading/writing page index #35934

Closed
pitrou opened this issue Jun 6, 2023 · 3 comments · Fixed by #36702
Closed

[C++] Benchmark reading/writing page index #35934

pitrou opened this issue Jun 6, 2023 · 3 comments · Fixed by #36702
Assignees
@mapleFU
Labels
Component: C++ Component: Parquet Type: enhancement
Milestone
14.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Jun 6, 2023

Describe the enhancement requested

I think it would be nice to benchmark reading and writing ColumnIndex and OffsetIndex.

Quite low priority, though.

Component(s)

C++
@pitrou
Copy link
Member Author

pitrou commented Jun 6, 2023

@wgtmac @mapleFU

@mapleFU
Copy link
Member

mapleFU commented Jun 6, 2023

Personally I guess bottleneck is doing io above Page Index...What interface should be benchmark here? Serialize and Deserialize?

@pitrou
Copy link
Member Author

pitrou commented Jun 6, 2023

Yes, serialize and deserialize, IMHO.

@github-actions github-actions bot mentioned this issue Jul 15, 2023
Merged
pitrou added a commit that referenced this issue Jul 18, 2023
@mapleFU @pitrou
GH-35934:[C++][Parquet] PageIndex Read benchmark (#36702)
f990406 
### Rationale for this change

Add benchmark for read page index 

### What changes are included in this PR?

Just a benchmark in `cpp/src/parquet/bloom_filter_benchmark.cc`

### Are these changes tested?

No

### Are there any user-facing changes?

No

* Closes: #35934

Lead-authored-by: mwish <maplewish117@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 14.0.0 milestone Jul 18, 2023
chelseajonesr pushed a commit to chelseajonesr/arrow that referenced this issue Jul 20, 2023
@mapleFU @pitrou @chelseajonesr
apacheGH-35934:[C++][Parquet] PageIndex Read benchmark (apache#36702)
80dfced 
### Rationale for this change

Add benchmark for read page index 

### What changes are included in this PR?

Just a benchmark in `cpp/src/parquet/bloom_filter_benchmark.cc`

### Are these changes tested?

No

### Are there any user-facing changes?

No

* Closes: apache#35934

Lead-authored-by: mwish <maplewish117@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@mapleFU @pitrou @R-JunmingChen
apacheGH-35934:[C++][Parquet] PageIndex Read benchmark (apache#36702)
5bfeba3 
### Rationale for this change

Add benchmark for read page index 

### What changes are included in this PR?

Just a benchmark in `cpp/src/parquet/bloom_filter_benchmark.cc`

### Are these changes tested?

No

### Are there any user-facing changes?

No

* Closes: apache#35934

Lead-authored-by: mwish <maplewish117@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Component: Parquet Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-35934:[C++][Parquet] PageIndex Read benchmark mapleFU/arrow
2 participants
@pitrou @mapleFU