You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[experimental] Singular, non-message typed fields in proto3 now support presence tracking. This is enabled by adding the "optional" field label and passing the --experimental_allow_proto3_optional flag to protoc.
optional was marked as a official feature in Protobuf 3.15.0:
If we accept Protobuf 3.12.0 or later by usung --experimental_allow_proto3_optional flag, we can use system Protobuf on Ubuntu 22.04. It reduces CI time and deb package build time.
Component(s)
C++, FlightRPC
The text was updated successfully, but these errors were encountered:
We can use `optional` with Protobuf 3.12.0 by specifying
`--experimental_allow_proto3_optional` explicitly.
If we accept Protobuf 3.12.0 or later for Flight SQL, we can use
system Protobuf on Ubuntu 22.04. Because Ubuntu 22.04 ships Protobuf
3.12.4.
We can use `optional` with Protobuf 3.12.0 by specifying
`--experimental_allow_proto3_optional` explicitly.
If we accept Protobuf 3.12.0 or later for Flight SQL, we can use
system Protobuf on Ubuntu 22.04. Because Ubuntu 22.04 ships Protobuf
3.12.4.
### Rationale for this change
We can use `optional` with Protobuf 3.12.0 by specifying `--experimental_allow_proto3_optional` explicitly.
If we accept Protobuf 3.12.0 or later for Flight SQL, we can use system Protobuf on Ubuntu 22.04. Because Ubuntu 22.04 ships Protobuf 3.12.4.
### What changes are included in this PR?
Specify `--experimental_allow_proto3_optional` explicitly when Protobuf is < 3.15.0.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
* Closes: #35961
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Describe the enhancement requested
FlightSql.proto
usesoptional
.optional
is added in Protobuf 3.12.0 as an experimental feature:https://github.com/protocolbuffers/protobuf/releases/tag/v3.12.0
optional
was marked as a official feature in Protobuf 3.15.0:https://github.com/protocolbuffers/protobuf/releases/tag/v3.15.0
We require Protobuf 3.15.0 or later for Flight SQL but Ubuntu 22.04 LTS ships Protobuf 3.12.4: https://packages.ubuntu.com/search?keywords=protobuf-compiler
If we accept Protobuf 3.12.0 or later by usung
--experimental_allow_proto3_optional
flag, we can use system Protobuf on Ubuntu 22.04. It reduces CI time and deb package build time.Component(s)
C++, FlightRPC
The text was updated successfully, but these errors were encountered: