Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decimal256DictionaryBuilder does not work correctly #35965

Closed
izveigor opened this issue Jun 7, 2023 · 0 comments · Fixed by #35966
Closed

Decimal256DictionaryBuilder does not work correctly #35965

izveigor opened this issue Jun 7, 2023 · 0 comments · Fixed by #35966
Assignees
@izveigor
Labels
Component: Go Type: bug
Milestone
13.0.0

Comments

@izveigor
Copy link
Contributor

izveigor commented Jun 7, 2023

Describe the bug, including details regarding any error messages, version, and platform.

Decimal256DictionaryBuilder cannot append decimal256 value and prefers decimal128 instead.

cannot use v (variable of type decimal256.Num) as decimal128.Num value in argument to builder.Append

The problem is in this line: https://github.com/apache/arrow/blob/main/go/arrow/array/dictionary.go#L1376

Component(s)

Go
@github-actions github-actions bot mentioned this issue Jun 7, 2023
Merged
zeroshade pushed a commit that referenced this issue Jun 7, 2023
@izveigor
GH-35965: [Go] Fix Decimal256DictionaryBuilder (#35966)
cd7f431 
### Rationale for this change
`Decimal256DictionaryBuilder` cannot append `decimal256` value and prefers `decimal128` instead.
```
cannot use v (variable of type decimal256.Num) as decimal128.Num value in argument to builder.Append
```

### What changes are included in this PR?

### Are these changes tested?
Yes

### Are there any user-facing changes?
Yes

* Closes: #35965

Authored-by: izveigor <izveigor@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 13.0.0 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@izveigor izveigor

Labels
Component: Go Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35965: [Go] Fix Decimal256DictionaryBuilder
2 participants
@zeroshade @izveigor