Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35965: [Go] Fix Decimal256DictionaryBuilder #35966

Merged
merged 1 commit into from
Jun 7, 2023
Merged

GH-35965: [Go] Fix Decimal256DictionaryBuilder #35966

merged 1 commit into from
Jun 7, 2023

Conversation

izveigor
Copy link
Contributor

@izveigor izveigor commented Jun 7, 2023

Rationale for this change

Decimal256DictionaryBuilder cannot append decimal256 value and prefers decimal128 instead.

cannot use v (variable of type decimal256.Num) as decimal128.Num value in argument to builder.Append

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

Yes

@izveigor izveigor requested a review from zeroshade as a code owner June 7, 2023 14:40
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

⚠️ GitHub issue #35965 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this oversight!

@zeroshade zeroshade merged commit cd7f431 into apache:main Jun 7, 2023
21 checks passed
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 7, 2023
@ursabot
Copy link

ursabot commented Jun 8, 2023

Benchmark runs are scheduled for baseline = 9630258 and contender = cd7f431. cd7f431 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.62% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.33% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.24% ⬆️0.06%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] cd7f431d ec2-t3-xlarge-us-east-2
[Finished] cd7f431d test-mac-arm
[Finished] cd7f431d ursa-i9-9960x
[Finished] cd7f431d ursa-thinkcentre-m75q
[Failed] 96302584 ec2-t3-xlarge-us-east-2
[Finished] 96302584 test-mac-arm
[Finished] 96302584 ursa-i9-9960x
[Finished] 96302584 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decimal256DictionaryBuilder does not work correctly
3 participants