Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] C Data Interface can't import decimal256 #35975

Closed
lidavidm opened this issue Jun 7, 2023 · 0 comments · Fixed by #35981
Closed

[Go] C Data Interface can't import decimal256 #35975

lidavidm opened this issue Jun 7, 2023 · 0 comments · Fixed by #35981
Assignees
@lidavidm
Labels
Component: Go Type: enhancement
Milestone
13.0.0

Comments

@lidavidm
Copy link
Member

lidavidm commented Jun 7, 2023

Describe the enhancement requested

It's just not implemented:

arrow/go/arrow/cdata/cdata.go

Lines 232 to 238 in 9be7074

case "d": // decimal types are d:<precision>,<scale>[,<bitsize>] size is assumed 128 if left out
props := typs[1]
propList := strings.Split(props, ",")
if len(propList) == 3 {
err = xerrors.New("only decimal128 is supported")
return
}

Component(s)

Go
@lidavidm lidavidm self-assigned this Jun 7, 2023
@zeroshade zeroshade changed the title [Go] C Data Interface can't import decimal128 [Go] C Data Interface can't import decimal256 Jun 7, 2023
This was referenced Jun 7, 2023
Merged
Closed
@github-actions github-actions bot mentioned this issue Jun 7, 2023
Merged
lidavidm added a commit to lidavidm/arrow that referenced this issue Jun 7, 2023
@lidavidm
apacheGH-35975: [Go] Support importing decimal256
ba9f624
lidavidm added a commit to lidavidm/arrow that referenced this issue Jun 7, 2023
@lidavidm
apacheGH-35975: [Go] Support importing decimal256
f4a9cdf
zeroshade pushed a commit that referenced this issue Jun 7, 2023
@lidavidm
GH-35975: [Go] Support importing decimal256 (#35981)
5e5002d 
### Rationale for this change

We didn't implement this type.

### What changes are included in this PR?

We now import this type. (And handle some other error cases.)

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #35975

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 13.0.0 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
Component: Go Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35975: [Go] Support importing decimal256 lidavidm/arrow
2 participants
@lidavidm @zeroshade