Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35975: [Go] Support importing decimal256 #35981

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Jun 7, 2023

Rationale for this change

We didn't implement this type.

What changes are included in this PR?

We now import this type. (And handle some other error cases.)

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@zeroshade zeroshade merged commit 5e5002d into apache:main Jun 7, 2023
20 of 21 checks passed
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 7, 2023
@lidavidm lidavidm deleted the gh-35975-decimal256 branch June 7, 2023 19:32
@ursabot
Copy link

ursabot commented Jun 9, 2023

Benchmark runs are scheduled for baseline = 9dd4c52 and contender = 5e5002d. 5e5002d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.59% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.33% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.24% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 5e5002de ec2-t3-xlarge-us-east-2
[Finished] 5e5002de test-mac-arm
[Failed] 5e5002de ursa-i9-9960x
[Finished] 5e5002de ursa-thinkcentre-m75q
[Finished] 9dd4c525 ec2-t3-xlarge-us-east-2
[Finished] 9dd4c525 test-mac-arm
[Finished] 9dd4c525 ursa-i9-9960x
[Finished] 9dd4c525 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Go] C Data Interface can't import decimal256
3 participants