Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] Require Node.js 18 or later #36055

Closed
kou opened this issue Jun 13, 2023 · 3 comments · Fixed by #36147
Closed

[JS] Require Node.js 18 or later #36055

kou opened this issue Jun 13, 2023 · 3 comments · Fixed by #36147
Assignees
@abetomo
Labels
Component: JavaScript Type: enhancement
Milestone
13.0.0

Comments

@kou
Copy link
Member

kou commented Jun 13, 2023 •
edited
Loading

Describe the enhancement requested

https://github.com/nodejs/release#release-schedule says that Node.js 16 will reach EOL on 2023-09-11.

Our JavaScript related CI jobs use Node.js 16:

Should we use Node.js 18 instead of 16?

@domoritz What do you think about this?

Component(s)

JavaScript
@domoritz
Copy link
Member

I already use newer node versions locally without issues so we should update the CI.

@kou
Copy link
Member Author

kou commented Jun 13, 2023

@abetomo Do you want to work on this?

@abetomo abetomo mentioned this issue Jun 14, 2023
Closed
@abetomo
Copy link
Contributor

abetomo commented Jun 14, 2023

take

abetomo added a commit to abetomo/arrow that referenced this issue Jun 16, 2023
@abetomo
apacheGH-36055: [JS] Use Node.js 18 in CI
f177bab 
Signed-off-by: abetomo <abe@enzou.tokyo>
@github-actions github-actions bot mentioned this issue Jun 17, 2023
Merged
kou pushed a commit that referenced this issue Jun 17, 2023
@abetomo
GH-36055: [JS] Use Node.js 18 in CI (#36147)
10e2090 
### Rationale for this change

Node.js 16 is soon to be EOL, so we will use Node.js 18 with CI.

### What changes are included in this PR?

Use Node.js 18 at `name: NodeJS` in GitHub Actions.

### Are these changes tested?

* I ran `archery docker run debian-js` locally and succeeded
* GitHub Actions `name: NodeJS` succeeds
    * https://github.com/abetomo/arrow/actions/runs/5289906862/jobs/9589326158
        * `docker` and `windows` succeeded
        * In the GitHub Actions for my repository, `macos` timed out. Has it happened before?

### Are there any user-facing changes?

* Closes: #36055

Authored-by: abetomo <abe@enzou.tokyo>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 13.0.0 milestone Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abetomo abetomo

Labels
Component: JavaScript Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36055: [JS] Use Node.js 18 in CI abetomo/arrow
3 participants
@kou @domoritz @abetomo