Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Remove deprecated equality checks #36198

Closed
metalmatze opened this issue Jun 21, 2023 · 0 comments · Fixed by #36169
Closed

[Go] Remove deprecated equality checks #36198

metalmatze opened this issue Jun 21, 2023 · 0 comments · Fixed by #36169
Assignees
@metalmatze
Labels
Component: Go Type: enhancement
Milestone
13.0.0

Comments

@metalmatze
Copy link
Contributor

Describe the enhancement requested

There are several deprecated comparison functions that have long been deprecated and were supposed to be removed in v9, we're working on v13 now.

I propose to remove those functions or at least remove several usages of those functions in the Go arrow package itself.

Component(s)

Go
@metalmatze metalmatze mentioned this issue Jun 21, 2023
Merged
zeroshade pushed a commit that referenced this issue Jun 21, 2023
@metalmatze
GH-36198: [Go] Remove deprecated equality checks (#36169)
5854d04 
### Rationale for this change

There are several deprecated comparison functions that have long been deprecated.
This PR unblocks the removal of those functions as nothing depends on them anymore.

Given the functions have been deprecated for a long time and might have been removed in v9, I removed them in this PR already, given this is for v13. 

### What changes are included in this PR?

### Are these changes tested?

Unit tests are passing locally. 

### Are there any user-facing changes?

Removal of old deprecated functions for comparing arrays. 

* Closes: #36198

Authored-by: Matthias Loibl <mail@matthiasloibl.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 13.0.0 milestone Jun 21, 2023
@kou kou changed the title Remove deprecated equality checks [Go] Remove deprecated equality checks Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metalmatze metalmatze

Labels
Component: Go Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36198: [Go] Remove deprecated equality checks metalmatze/arrow
2 participants
@zeroshade @metalmatze