Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Split out R6 classes and convenience functions #36271

Closed
8 tasks done
thisisnic opened this issue Jun 23, 2023 · 2 comments · Fixed by #36394
Closed
8 tasks done

[R] Split out R6 classes and convenience functions #36271

thisisnic opened this issue Jun 23, 2023 · 2 comments · Fixed by #36394
Assignees
@thisisnic
Labels
Component: R Type: enhancement
Milestone
13.0.0

Comments

@thisisnic
Copy link
Member

thisisnic commented Jun 23, 2023 •
edited

Describe the enhancement requested

In the process of #35545 it's become apparent that there are a few ways in which we can improve how we document our data containers:

Split out docs for:

  • chunked_array()

  • record_batch()

  • arrow_table()

  • buffer()
    to start with "Create a ..." to make the intention of the function more clear

  • Update the title for read_schema() to begin with a capital letter

  • Update the following functions' titles to being with a verb:

    • schema()
    • field()
    • data-type

Component(s)

R
@thisisnic thisisnic self-assigned this Jun 23, 2023
@thisisnic thisisnic changed the title [R] Split out the function for creating arrays from the other classes [R] Improve @title param for multiple functions Jun 23, 2023
@thisisnic thisisnic changed the title [R] Improve @title param for multiple functions [R] Split out R6 classes and convenience functions Jun 29, 2023
@thisisnic thisisnic mentioned this issue Jun 30, 2023
Merged
thisisnic added a commit that referenced this issue Jul 11, 2023
@thisisnic
GH-36271: [R] Split out R6 classes and convenience functions (#36394)
2bd031a 
Closes: #36271 
* Closes: #36271

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@thisisnic thisisnic added this to the 13.0.0 milestone Jul 11, 2023
@raulcd
Copy link
Member

raulcd commented Jul 11, 2023

@thisisnic this has been tagged as 13.0.0, were you expecting this to be added to the release?

@thisisnic
Copy link
Member Author

Yes please!

raulcd pushed a commit that referenced this issue Jul 13, 2023
@thisisnic @raulcd
GH-36271: [R] Split out R6 classes and convenience functions (#36394)
dc6954a 
Closes: #36271 
* Closes: #36271

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisnic thisisnic

Labels
Component: R Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36271: [R] Split out R6 classes and convenience functions thisisnic/arrow
2 participants
@raulcd @thisisnic