Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Add missing move semantic to RecordBatch #36342

Closed
zhjwpku opened this issue Jun 28, 2023 · 0 comments · Fixed by #36343
Closed

[C++] Add missing move semantic to RecordBatch #36342

zhjwpku opened this issue Jun 28, 2023 · 0 comments · Fixed by #36343
Assignees
@zhjwpku
Labels
Component: C++ Type: enhancement
Milestone
13.0.0

Comments

@zhjwpku
Copy link
Contributor

zhjwpku commented Jun 28, 2023

Describe the enhancement requested

In file record_batch.cc there are some places that using move semantic can avoid coping vector or increasing reference count of shared_ptr.

Component(s)

C++
zhjwpku added a commit to zhjwpku/arrow that referenced this issue Jun 28, 2023
@zhjwpku
apacheGH-36342: [C++] Add missing move semantic to RecordBatch
03b8319 
In file record_batch.cc there are some places that using move semantic
can avoid coping vector or increasing reference count of shared_ptr.

Signed-off-by: Zhao Junwang <zhjwpku@gmail.com>
@github-actions github-actions bot mentioned this issue Jun 28, 2023
Merged
pitrou pushed a commit that referenced this issue Jun 28, 2023
@zhjwpku
GH-36342: [C++] Add missing move semantic to RecordBatch (#36343)
68a30f6 
### Rationale for this change

In file record_batch.cc there are some places that using move semantic can avoid coping vector or increasing reference count of shared_ptr.

### What changes are included in this PR?

add std::move at some proper places

### Are these changes tested?

Yes, run `ctest -R arrow-table-test` locally.

### Are there any user-facing changes?

No

* Closes: #36342

Authored-by: Zhao Junwang <zhjwpku@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 13.0.0 milestone Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhjwpku zhjwpku

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36342: [C++] Add missing move semantic to RecordBatch zhjwpku/arrow
2 participants
@pitrou @zhjwpku