GH-36342: [C++] Add missing move semantic to RecordBatch #36343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In file record_batch.cc there are some places that using move semantic can avoid coping vector or increasing reference count of shared_ptr. Signed-off-by: Zhao Junwang <zhjwpku@gmail.com>
|
|
pitrou
approved these changes
Jun 28, 2023
github-actions
bot
added
awaiting committer review
|
CI failures are unrelated, will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In file record_batch.cc there are some places that using move semantic can avoid coping vector or increasing reference count of shared_ptr.
What changes are included in this PR?
add std::move at some proper places
Are these changes tested?
Yes, run
ctest -R arrow-table-testlocally.Are there any user-facing changes?
No