Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python][CI] The "Without Pandas" CI build to run nopandas tests actually has pandas installed #36541

Closed
jorisvandenbossche opened this issue Jul 7, 2023 · 0 comments · Fixed by #36542 or #36586
Closed

[Python][CI] The "Without Pandas" CI build to run nopandas tests actually has pandas installed #36541

jorisvandenbossche opened this issue Jul 7, 2023 · 0 comments · Fixed by #36542 or #36586
Assignees
@jorisvandenbossche
Labels
Component: Continuous Integration Component: Python
Milestone
13.0.0

Comments

@jorisvandenbossche
Copy link
Member

See for example https://github.com/ursacomputing/crossbow/actions/runs/5476945590/jobs/9975241254, the pandas tests are not skipped.
This was a consequence of the combination of adding pandas to the docs requirements (#13714) and installing conda_env_sphinx.txt into the base conda-python docker image (https://github.com/apache/arrow/pull/11567/files#diff-63f460890faace8e0ac2e8e679de7ff8e4ff46a6ac512d53a85fa142b714d2c9)
@github-actions github-actions bot mentioned this issue Jul 7, 2023
Merged
@kou kou closed this as completed in #36542 Jul 8, 2023
kou pushed a commit that referenced this issue Jul 8, 2023
@jorisvandenbossche
GH-36541: [Python][CI] Ensure the "Without pandas" CI build has no pa…
feb128e 
…ndas installed (don't install doc requirements in conda-python image) (#36542)

### Rationale for this change

The "Without Pandas" CI build is actually having pandas installed and thus not testing the case of an environment without pandas. 

* Closes: #36541

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 13.0.0 milestone Jul 8, 2023
@github-actions github-actions bot mentioned this issue Jul 10, 2023
Merged
jorisvandenbossche added a commit that referenced this issue Jul 10, 2023
@jorisvandenbossche
GH-36541: [Python][CI] Fixup nopandas build after merge of GH-33321 (#…
1040e2c 
…36586)

See https://github.com/apache/arrow/pull/35656/files#r1257540254

#36542 fixed the no-pandas build by actually not having pandas installed, but some PRs merged at the same time introduced new failures for this build.
* Closes: #36541

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorisvandenbossche jorisvandenbossche

Labels
Component: Continuous Integration Component: Python
Projects
None yet
Milestone
13.0.0
2 participants
@kou @jorisvandenbossche