Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-36541: [Python][CI] Ensure the "Without pandas" CI build has no pandas installed (don't install doc requirements in conda-python image) #36542

Merged
merged 3 commits into from
Jul 8, 2023
Merged

GH-36541: [Python][CI] Ensure the "Without pandas" CI build has no pandas installed (don't install doc requirements in conda-python image) #36542

merged 3 commits into from
Jul 8, 2023

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Jul 7, 2023 •
edited by github-actions bot

Rationale for this change

The "Without Pandas" CI build is actually having pandas installed and thus not testing the case of an environment without pandas.

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit python

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

⚠️ GitHub issue #36541 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Revision: 392827d

Submitted crossbow builds: ursacomputing/crossbow @ actions-7022257121

Task Status
example-python-minimal-build-fedora-conda Github Actions
example-python-minimal-build-ubuntu-venv Github Actions
python-sdist Github Actions
test-conda-python-3.10 Github Actions
test-conda-python-3.10-hdfs-2.9.2 Github Actions
test-conda-python-3.10-hdfs-3.2.1 Github Actions
test-conda-python-3.10-pandas-latest Github Actions
test-conda-python-3.10-pandas-nightly Github Actions
test-conda-python-3.10-spark-master Github Actions
test-conda-python-3.10-substrait Github Actions
test-conda-python-3.11 Github Actions
test-conda-python-3.11-dask-latest Github Actions
test-conda-python-3.11-dask-upstream_devel Github Actions
test-conda-python-3.11-hypothesis Github Actions
test-conda-python-3.11-pandas-upstream_devel Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-pandas-1.0 Github Actions
test-conda-python-3.8-spark-v3.1.2 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-pandas-latest Github Actions
test-conda-python-3.9-spark-v3.2.0 Github Actions
test-cuda-python Github Actions
test-debian-11-python-3 Azure
test-fedora-35-python-3 Azure
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-python-3 Github Actions
verify-rc-source-python-linux-almalinux-8-amd64 Github Actions
verify-rc-source-python-linux-conda-latest-amd64 Github Actions
verify-rc-source-python-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-python-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-python-macos-amd64 Github Actions
verify-rc-source-python-macos-arm64 Github Actions
verify-rc-source-python-macos-conda-amd64 Github Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit python

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Revision: ffb88ad

Submitted crossbow builds: ursacomputing/crossbow @ actions-2db0b79ae4

Task Status
example-python-minimal-build-fedora-conda Github Actions
example-python-minimal-build-ubuntu-venv Github Actions
python-sdist Github Actions
test-conda-python-3.10 Github Actions
test-conda-python-3.10-hdfs-2.9.2 Github Actions
test-conda-python-3.10-hdfs-3.2.1 Github Actions
test-conda-python-3.10-pandas-latest Github Actions
test-conda-python-3.10-pandas-nightly Github Actions
test-conda-python-3.10-spark-master Github Actions
test-conda-python-3.10-substrait Github Actions
test-conda-python-3.11 Github Actions
test-conda-python-3.11-dask-latest Github Actions
test-conda-python-3.11-dask-upstream_devel Github Actions
test-conda-python-3.11-hypothesis Github Actions
test-conda-python-3.11-pandas-upstream_devel Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-pandas-1.0 Github Actions
test-conda-python-3.8-spark-v3.1.2 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-pandas-latest Github Actions
test-conda-python-3.9-spark-v3.2.0 Github Actions
test-cuda-python Github Actions
test-debian-11-python-3 Azure
test-fedora-35-python-3 Azure
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-python-3 Github Actions
verify-rc-source-python-linux-almalinux-8-amd64 Github Actions
verify-rc-source-python-linux-conda-latest-amd64 Github Actions
verify-rc-source-python-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-python-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-python-macos-amd64 Github Actions
verify-rc-source-python-macos-arm64 Github Actions
verify-rc-source-python-macos-conda-amd64 Github Actions

kou
kou approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit feb128e into apache:main Jul 8, 2023
47 of 49 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Jul 8, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jul 8, 2023
@kou kou mentioned this pull request Jul 9, 2023
Merged
@jorisvandenbossche jorisvandenbossche deleted the gh-36541-nopandas-ci branch July 10, 2023 06:30
@jorisvandenbossche jorisvandenbossche mentioned this pull request Jul 10, 2023
Merged
jorisvandenbossche added a commit that referenced this pull request Jul 10, 2023
@jorisvandenbossche
GH-36541: [Python][CI] Fixup nopandas build after merge of GH-33321 (#…
1040e2c 
…36586)

See https://github.com/apache/arrow/pull/35656/files#r1257540254

#36542 fixed the no-pandas build by actually not having pandas installed, but some PRs merged at the same time introduced new failures for this build.
* Closes: #36541

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@conbench-apache-arrow
Copy link

Conbench analyzed the 6 benchmark runs on commit feb128e6.

There were 8 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

@AlenkaF AlenkaF Awaiting requested review from AlenkaF

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python][CI] The "Without Pandas" CI build to run nopandas tests actually has pandas installed
2 participants
@jorisvandenbossche @kou