[C++][Gandiva] MSVC_VERSION not handled correctly

[h-vetinari]

Describe the bug, including details regarding any error messages, version, and platform.

The following logic is deficient:

arrow/cpp/src/gandiva/precompiled/CMakeLists.txt

Lines 33 to 47 in 05620b1

	if(MSVC)
	# clang pretends to be a particular version of MSVC. Thestandard
	# library uses C++14 features, so we have to use that -std version
	# to get the IR compilation to work.
	# See https://cmake.org/cmake/help/latest/variable/MSVC_VERSION.html
	# for MSVC_VERSION and Visual Studio version.
	if(MSVC_VERSION LESS 1930)
	set(FMS_COMPATIBILITY 19.20)
	elseif(MSVC_VERSION LESS 1920)
	set(FMS_COMPATIBILITY 19.10)
	else()
	message(FATAL_ERROR "Unsupported MSVC_VERSION=${MSVC_VERSION}")
	endif()
	set(PLATFORM_CLANG_OPTIONS -std=c++17 -fms-compatibility
	-fms-compatibility-version=${FMS_COMPATIBILITY})

It will never reach the elseif or the else (as it just decides between <1930, yes or no), and will pass an empty FMS_COMPATIBILITY for VS2022.

Also worth noting, elsewhere MSVC_VERSION uses 19, and not 19xx. This is also wrong according to the CMake docs.

Component(s)

C++ - Gandiva