Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] util_avx2.cc has been moved to compute but still #include acero headers #36641

Closed
Riatre opened this issue Jul 12, 2023 · 1 comment · Fixed by #36650
Closed

[C++] util_avx2.cc has been moved to compute but still #include acero headers #36641

Riatre opened this issue Jul 12, 2023 · 1 comment · Fixed by #36650
Assignees
@westonpace
Labels
Component: C++ Priority: Critical Type: bug
Milestone
13.0.0

Comments

@Riatre
Copy link

Riatre commented Jul 12, 2023

Describe the bug, including details regarding any error messages, version, and platform.

It looks like #35115 moved util_avx2.cc from acero/ to compute/ but forgot to update #include lines. This was discovered while building Apache Arrow with a sandboxed build system where the entire acero/ is not visible if ARROW_ACERO=OFF.

Component(s)

C++
@westonpace westonpace added Priority: Critical Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. labels Jul 12, 2023
@github-actions github-actions bot mentioned this issue Jul 12, 2023
Merged
@jorisvandenbossche jorisvandenbossche added this to the 13.0.0 milestone Jul 13, 2023
@jorisvandenbossche
Copy link
Member

This should be included in 13.0.0?

pitrou added a commit that referenced this issue Jul 13, 2023
@westonpace @pitrou
GH-36641: [C++] Remove reference to acero from non-acero file (#36650)
fbf8a97 
### Rationale for this change

Files in modules which do not depend on the acero module should not reference files inside the acero module.

### What changes are included in this PR?

There were no changes to the body of any functions.  I simply moved functions around so that the acero include was no longer needed.  There were some conflicts that arose between the class `bit_util` and the namespace `bit_util` and so I got rid of the class in favor of the namespace as that is more similar to how we handle `bit_util` elsewhere.

### Are these changes tested?

Sort of.  I would like to add an AVX2 CI system as well.  I'm not confident any of the CI builds are building with AVX2 enabled.  Also, even if we have an AVX2 CI system it would not have caught this issue since the code was only needed definitions from the acero header and was not relying on any actual compiled symbols.  However, I think setting up tests to catch this sort of invalid include are beyond the scope of this PR.

### Are there any user-facing changes?

No.
* Closes: #36641

Lead-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou modified the milestones: 13.0.0, 14.0.0 Jul 13, 2023
@jorisvandenbossche jorisvandenbossche modified the milestones: 14.0.0, 13.0.0 Jul 13, 2023
raulcd pushed a commit that referenced this issue Jul 13, 2023
@westonpace @pitrou @raulcd
GH-36641: [C++] Remove reference to acero from non-acero file (#36650)
629c6a1 
### Rationale for this change

Files in modules which do not depend on the acero module should not reference files inside the acero module.

### What changes are included in this PR?

There were no changes to the body of any functions.  I simply moved functions around so that the acero include was no longer needed.  There were some conflicts that arose between the class `bit_util` and the namespace `bit_util` and so I got rid of the class in favor of the namespace as that is more similar to how we handle `bit_util` elsewhere.

### Are these changes tested?

Sort of.  I would like to add an AVX2 CI system as well.  I'm not confident any of the CI builds are building with AVX2 enabled.  Also, even if we have an AVX2 CI system it would not have caught this issue since the code was only needed definitions from the acero header and was not relying on any actual compiled symbols.  However, I think setting up tests to catch this sort of invalid include are beyond the scope of this PR.

### Are there any user-facing changes?

No.
* Closes: #36641

Lead-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
chelseajonesr pushed a commit to chelseajonesr/arrow that referenced this issue Jul 20, 2023
@westonpace @pitrou @chelseajonesr
apacheGH-36641: [C++] Remove reference to acero from non-acero file (a…
a997665 
…pache#36650)

### Rationale for this change

Files in modules which do not depend on the acero module should not reference files inside the acero module.

### What changes are included in this PR?

There were no changes to the body of any functions.  I simply moved functions around so that the acero include was no longer needed.  There were some conflicts that arose between the class `bit_util` and the namespace `bit_util` and so I got rid of the class in favor of the namespace as that is more similar to how we handle `bit_util` elsewhere.

### Are these changes tested?

Sort of.  I would like to add an AVX2 CI system as well.  I'm not confident any of the CI builds are building with AVX2 enabled.  Also, even if we have an AVX2 CI system it would not have caught this issue since the code was only needed definitions from the acero header and was not relying on any actual compiled symbols.  However, I think setting up tests to catch this sort of invalid include are beyond the scope of this PR.

### Are there any user-facing changes?

No.
* Closes: apache#36641

Lead-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@westonpace @pitrou @R-JunmingChen
apacheGH-36641: [C++] Remove reference to acero from non-acero file (a…
df63f97 
…pache#36650)

### Rationale for this change

Files in modules which do not depend on the acero module should not reference files inside the acero module.

### What changes are included in this PR?

There were no changes to the body of any functions.  I simply moved functions around so that the acero include was no longer needed.  There were some conflicts that arose between the class `bit_util` and the namespace `bit_util` and so I got rid of the class in favor of the namespace as that is more similar to how we handle `bit_util` elsewhere.

### Are these changes tested?

Sort of.  I would like to add an AVX2 CI system as well.  I'm not confident any of the CI builds are building with AVX2 enabled.  Also, even if we have an AVX2 CI system it would not have caught this issue since the code was only needed definitions from the acero header and was not relying on any actual compiled symbols.  However, I think setting up tests to catch this sort of invalid include are beyond the scope of this PR.

### Are there any user-facing changes?

No.
* Closes: apache#36641

Lead-authored-by: Weston Pace <weston.pace@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@raulcd raulcd removed the Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonpace westonpace

Labels
Component: C++ Priority: Critical Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36641: [C++] Remove reference to acero from non-acero file westonpace/arrow
5 participants
@raulcd @jorisvandenbossche @westonpace @pitrou @Riatre