Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] util_avx2.cc is in acero but should be in compute #35115

Closed
westonpace opened this issue Apr 13, 2023 · 0 comments · Fixed by #35117
Closed

[C++] util_avx2.cc is in acero but should be in compute #35115

westonpace opened this issue Apr 13, 2023 · 0 comments · Fixed by #35117
Assignees
@westonpace
Labels
Component: C++ Priority: Blocker Marks a blocker for the release Type: bug
Milestone
12.0.0

Comments

@westonpace
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

As part of the split to acero the file arrow/compute/util.cc and arrow/util/compute/exec/util.cc got moved around a bit. It seems that util_avx2.cc ended up in acero but it's functions are actually needed by parquet. This means, when compiling with AVX2, you will get undefined symbol errors if you try to use parquet.

Component(s)

C++
@westonpace westonpace changed the title util_avx2.cc is in acero but should be in compute [C++] util_avx2.cc is in acero but should be in compute Apr 13, 2023
@github-actions github-actions bot mentioned this issue Apr 13, 2023
Merged
@jorisvandenbossche jorisvandenbossche added this to the 12.0.0 milestone Apr 13, 2023
@westonpace westonpace added the Priority: Blocker Marks a blocker for the release label Apr 14, 2023
westonpace added a commit that referenced this issue Apr 18, 2023
@westonpace
GH-35115: [C++] Moved util_avx2.cc from acero to compute (#35117)
ae633bc 
### Rationale for this change

The file util_avx2.cc contains implementation for methods defined in `src/arrow/compute/util.cc` but it was placed in `src/arrow/acero`.  This leads to undefined symbol errors when compiling against AVX2.

### What changes are included in this PR?

The file util_avx2.cc is moved from `acero` to `compute`.

### Are these changes tested?

Regrettably, no.  See #35116 

### Are there any user-facing changes?

No.
* Closes: #35115

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace modified the milestones: 12.0.0, 13.0.0 Apr 18, 2023
raulcd pushed a commit that referenced this issue Apr 19, 2023
@westonpace @raulcd
GH-35115: [C++] Moved util_avx2.cc from acero to compute (#35117)
e95089e 
### Rationale for this change

The file util_avx2.cc contains implementation for methods defined in `src/arrow/compute/util.cc` but it was placed in `src/arrow/acero`.  This leads to undefined symbol errors when compiling against AVX2.

### What changes are included in this PR?

The file util_avx2.cc is moved from `acero` to `compute`.

### Are these changes tested?

Regrettably, no.  See #35116 

### Are there any user-facing changes?

No.
* Closes: #35115

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
@westonpace @liujiacheng777
apacheGH-35115: [C++] Moved util_avx2.cc from acero to compute (apach…
8287c45 
…e#35117)

### Rationale for this change

The file util_avx2.cc contains implementation for methods defined in `src/arrow/compute/util.cc` but it was placed in `src/arrow/acero`.  This leads to undefined symbol errors when compiling against AVX2.

### What changes are included in this PR?

The file util_avx2.cc is moved from `acero` to `compute`.

### Are these changes tested?

Regrettably, no.  See apache#35116 

### Are there any user-facing changes?

No.
* Closes: apache#35115

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
@westonpace @ArgusLi
apacheGH-35115: [C++] Moved util_avx2.cc from acero to compute (apach…
301bf1d 
…e#35117)

### Rationale for this change

The file util_avx2.cc contains implementation for methods defined in `src/arrow/compute/util.cc` but it was placed in `src/arrow/acero`.  This leads to undefined symbol errors when compiling against AVX2.

### What changes are included in this PR?

The file util_avx2.cc is moved from `acero` to `compute`.

### Are these changes tested?

Regrettably, no.  See apache#35116 

### Are there any user-facing changes?

No.
* Closes: apache#35115

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
@westonpace @rtpsw
apacheGH-35115: [C++] Moved util_avx2.cc from acero to compute (apach…
53ee1e2 
…e#35117)

### Rationale for this change

The file util_avx2.cc contains implementation for methods defined in `src/arrow/compute/util.cc` but it was placed in `src/arrow/acero`.  This leads to undefined symbol errors when compiling against AVX2.

### What changes are included in this PR?

The file util_avx2.cc is moved from `acero` to `compute`.

### Are these changes tested?

Regrettably, no.  See apache#35116 

### Are there any user-facing changes?

No.
* Closes: apache#35115

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@Riatre Riatre mentioned this issue Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonpace westonpace

Labels
Component: C++ Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-35115: [C++] Moved util_avx2.cc from acero to compute westonpace/arrow
2 participants
@jorisvandenbossche @westonpace