Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] pyarrow.dataset.Partitioning.__eq__ crashes when comparing with other type #36659

Closed
jorisvandenbossche opened this issue Jul 13, 2023 · 0 comments · Fixed by #36661
Closed

[Python] pyarrow.dataset.Partitioning.__eq__ crashes when comparing with other type #36659

jorisvandenbossche opened this issue Jul 13, 2023 · 0 comments · Fixed by #36661
Assignees
@jorisvandenbossche
Labels
Component: Python Type: bug
Milestone
13.0.0

Comments

@jorisvandenbossche
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

We are not correctly verifying the other, so get a segfault:

In [9]: part = ds.partitioning(pa.schema([("part", "string")]), flavor="hive")

In [10]: part == "hive"
Segmentation fault (core dumped)

Component(s)

Python
@jorisvandenbossche jorisvandenbossche added this to the 13.0.0 milestone Jul 13, 2023
jorisvandenbossche added a commit to jorisvandenbossche/arrow that referenced this issue Jul 13, 2023
@jorisvandenbossche
apacheGH-36659: [Python] Fix pyarrow.dataset.Partitioning.__eq__ when…
492ba09 
… comparing with other type
@github-actions github-actions bot mentioned this issue Jul 13, 2023
Merged
jorisvandenbossche added a commit that referenced this issue Jul 13, 2023
@jorisvandenbossche
GH-36659: [Python] Fix pyarrow.dataset.Partitioning.__eq__ when compa…
994c73b 
…ring with other type (#36661)

### Rationale for this change

Ensure that `part == other` doesn't crash with `other` is not a Partitioning instance

Small follow-up on #36462

* Closes: #36659

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
raulcd pushed a commit that referenced this issue Jul 13, 2023
@jorisvandenbossche @raulcd
GH-36659: [Python] Fix pyarrow.dataset.Partitioning.__eq__ when compa…
b4c3b41 
…ring with other type (#36661)

### Rationale for this change

Ensure that `part == other` doesn't crash with `other` is not a Partitioning instance

Small follow-up on #36462

* Closes: #36659

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
chelseajonesr pushed a commit to chelseajonesr/arrow that referenced this issue Jul 20, 2023
@jorisvandenbossche @chelseajonesr
apacheGH-36659: [Python] Fix pyarrow.dataset.Partitioning.__eq__ when…
23bf390 
… comparing with other type (apache#36661)

### Rationale for this change

Ensure that `part == other` doesn't crash with `other` is not a Partitioning instance

Small follow-up on apache#36462

* Closes: apache#36659

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@jorisvandenbossche @R-JunmingChen
apacheGH-36659: [Python] Fix pyarrow.dataset.Partitioning.__eq__ when…
276e99b 
… comparing with other type (apache#36661)

### Rationale for this change

Ensure that `part == other` doesn't crash with `other` is not a Partitioning instance

Small follow-up on apache#36462

* Closes: apache#36659

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorisvandenbossche jorisvandenbossche

Labels
Component: Python Type: bug
Projects
None yet
Milestone
13.0.0
1 participant
@jorisvandenbossche