Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Remove AWS SDK bundling when building wheels #36752

Closed
pitrou opened this issue Jul 18, 2023 · 1 comment · Fixed by #36925
Closed

[Python] Remove AWS SDK bundling when building wheels #36752

pitrou opened this issue Jul 18, 2023 · 1 comment · Fixed by #36925
Assignees
@raulcd
Labels
Component: Packaging Component: Python
Milestone
14.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Jul 18, 2023

Describe the enhancement requested

In #12227 we decided to use a bundled version of the AWS SDK when compiling Python wheels, in order to downgrade the AWS SDK version.

Now that we have fixed S3 finalization issues (#36442), it should be ok to rely on the vcpkg-installed version of the AWS SDK again.

Component(s)

Packaging, Python
@pitrou
Copy link
Member Author

pitrou commented Jul 18, 2023

@raulcd

raulcd added a commit to raulcd/arrow that referenced this issue Jul 28, 2023
@raulcd
apacheGH-36752: [Python] Remove AWS SDK bundling when building wheels
887cb1d
@github-actions github-actions bot mentioned this issue Jul 28, 2023
Merged
raulcd added a commit to raulcd/arrow that referenced this issue Aug 1, 2023
@raulcd
apacheGH-36752: [Python] Remove AWS SDK bundling when building wheels
2a9be02
@kou kou closed this as completed in #36925 Aug 3, 2023
kou pushed a commit that referenced this issue Aug 3, 2023
@raulcd
GH-36752: [Python] Remove AWS SDK bundling when building wheels (#36925)
9b3bf08 
### Rationale for this change

In #12227 we decided to use a bundled version of the AWS SDK when compiling Python wheels, in order to downgrade the AWS SDK version.

Now that we have fixed S3 finalization issues (#36442), it should be ok to rely on the vcpkg-installed version of the AWS SDK again.

### What changes are included in this PR?

Remove use of bundled AWS SDK and use S3 vcpkg feature for requirements.

### Are these changes tested?

On CI and via crossbow

### Are there any user-facing changes?

No
* Closes: #36752

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Aug 3, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@raulcd @loicalleyne
apacheGH-36752: [Python] Remove AWS SDK bundling when building wheels (…
cb51f90 
…apache#36925)

### Rationale for this change

In apache#12227 we decided to use a bundled version of the AWS SDK when compiling Python wheels, in order to downgrade the AWS SDK version.

Now that we have fixed S3 finalization issues (apache#36442), it should be ok to rely on the vcpkg-installed version of the AWS SDK again.

### What changes are included in this PR?

Remove use of bundled AWS SDK and use S3 vcpkg feature for requirements.

### Are these changes tested?

On CI and via crossbow

### Are there any user-facing changes?

No
* Closes: apache#36752

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulcd raulcd

Labels
Component: Packaging Component: Python
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36752: [Python] Remove AWS SDK bundling when building wheels raulcd/arrow
3 participants
@kou @raulcd @pitrou