-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36752: [Python] Remove AWS SDK bundling when building wheels #36925
Conversation
@github-actions crossbow submit -g wheel |
|
@github-actions crossbow submit java-jars |
Revision: 887cb1d Submitted crossbow builds: ursacomputing/crossbow @ actions-fdcf65c07d |
Revision: 887cb1d Submitted crossbow builds: ursacomputing/crossbow @ actions-1b69832c2b
|
@github-actions crossbow submit java-jars |
Revision: 241e89c Submitted crossbow builds: ursacomputing/crossbow @ actions-9d816ef1c2
|
Thanks @kou, I didn't see that one :) |
@github-actions crossbow submit -g wheel |
Revision: 1fb7e2c Submitted crossbow builds: ursacomputing/crossbow @ actions-33ffe17146 |
@github-actions crossbow submit wheel-windows-cp310-amd64 |
Revision: c04d057 Submitted crossbow builds: ursacomputing/crossbow @ actions-c3320dac1a
|
The Windows wheel failure is now unrelated, see the above issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 9b3bf08. There were 3 benchmark results indicating a performance regression:
The full Conbench report has more details. |
…apache#36925) ### Rationale for this change In apache#12227 we decided to use a bundled version of the AWS SDK when compiling Python wheels, in order to downgrade the AWS SDK version. Now that we have fixed S3 finalization issues (apache#36442), it should be ok to rely on the vcpkg-installed version of the AWS SDK again. ### What changes are included in this PR? Remove use of bundled AWS SDK and use S3 vcpkg feature for requirements. ### Are these changes tested? On CI and via crossbow ### Are there any user-facing changes? No * Closes: apache#36752 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
In #12227 we decided to use a bundled version of the AWS SDK when compiling Python wheels, in order to downgrade the AWS SDK version.
Now that we have fixed S3 finalization issues (#36442), it should be ok to rely on the vcpkg-installed version of the AWS SDK again.
What changes are included in this PR?
Remove use of bundled AWS SDK and use S3 vcpkg feature for requirements.
Are these changes tested?
On CI and via crossbow
Are there any user-facing changes?
No