Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Parquet] Parquet: buffered column writer uses unbuffered page writer #36828

Closed
mapleFU opened this issue Jul 23, 2023 · 1 comment · Fixed by #36829
Closed

[C++][Parquet] Parquet: buffered column writer uses unbuffered page writer #36828

mapleFU opened this issue Jul 23, 2023 · 1 comment · Fixed by #36829

Comments

@mapleFU
Copy link
Member

mapleFU commented Jul 23, 2023

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/apache/arrow/pull/35886/files#r1271424177

In RowGroupSerializer::InitColumns, the buffered flag is ignored after #35886. Causing Buffered RowGroup Writer uses unbuffered page writer.

Component(s)

C++, Parquet

@mapleFU
Copy link
Member Author

mapleFU commented Jul 23, 2023

This might be a blocker in 13.0.0 @raulcd , so sorry for that !

wgtmac pushed a commit that referenced this issue Jul 24, 2023
…redPageWriter (#36829)

### Rationale for this change

See #36828

### What changes are included in this PR?

Add `buffered` argument when building `PageWriter`

### Are these changes tested?

no

### Are there any user-facing changes?

no

* Closes: #36828

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Gang Wu <ustcwg@gmail.com>
@wgtmac wgtmac added this to the 14.0.0 milestone Jul 24, 2023
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
… BufferedPageWriter (apache#36829)

### Rationale for this change

See apache#36828

### What changes are included in this PR?

Add `buffered` argument when building `PageWriter`

### Are these changes tested?

no

### Are there any user-facing changes?

no

* Closes: apache#36828

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Gang Wu <ustcwg@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
… BufferedPageWriter (apache#36829)

### Rationale for this change

See apache#36828

### What changes are included in this PR?

Add `buffered` argument when building `PageWriter`

### Are these changes tested?

no

### Are there any user-facing changes?

no

* Closes: apache#36828

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Gang Wu <ustcwg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants