Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Unify OpenSSL detection for building GCS #36944

Closed
kou opened this issue Jul 31, 2023 · 0 comments · Fixed by #36945
Closed

[C++] Unify OpenSSL detection for building GCS #36944

kou opened this issue Jul 31, 2023 · 0 comments · Fixed by #36945
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
14.0.0

Comments

@kou
Copy link
Member

kou commented Jul 31, 2023

Describe the enhancement requested

build_google_cloud_cpp_storage() calls resolve_dependency(OpenSSL) but it should not be here. We should have only one resolve_dependency(OpenSSL) for easy to maintain.

Component(s)

C++
kou added a commit to kou/arrow that referenced this issue Jul 31, 2023
@kou
apacheGH-36944: [C++] Unify OpenSSL detection for building GCS
198ad01
@github-actions github-actions bot mentioned this issue Jul 31, 2023
Merged
kou added a commit that referenced this issue Jul 31, 2023
@kou
GH-36944: [C++] Unify OpenSSL detection for building GCS (#36945)
eddb2b9 
### Rationale for this change

`build_google_cloud_cpp_storage()` calls `resolve_dependency(OpenSSL)` but it should not be here. We should have only one `resolve_dependency(OpenSSL)` for easy to maintain.

### What changes are included in this PR?

Don't call `resolve_dependency(OpenSSL)` from `build_google_cloud_cpp_storage()`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #36944

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Jul 31, 2023
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@kou @R-JunmingChen
apacheGH-36944: [C++] Unify OpenSSL detection for building GCS (apach…
3241def 
…e#36945)

### Rationale for this change

`build_google_cloud_cpp_storage()` calls `resolve_dependency(OpenSSL)` but it should not be here. We should have only one `resolve_dependency(OpenSSL)` for easy to maintain.

### What changes are included in this PR?

Don't call `resolve_dependency(OpenSSL)` from `build_google_cloud_cpp_storage()`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#36944

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@kou @loicalleyne
apacheGH-36944: [C++] Unify OpenSSL detection for building GCS (apach…
da24a77 
…e#36945)

### Rationale for this change

`build_google_cloud_cpp_storage()` calls `resolve_dependency(OpenSSL)` but it should not be here. We should have only one `resolve_dependency(OpenSSL)` for easy to maintain.

### What changes are included in this PR?

Don't call `resolve_dependency(OpenSSL)` from `build_google_cloud_cpp_storage()`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#36944

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36944: [C++] Unify OpenSSL detection for building GCS kou/arrow
1 participant
@kou