GH-36944: [C++] Unify OpenSSL detection for building GCS #36945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
@github-actions crossbow submit -g cpp |
|
Revision: 198ad01 Submitted crossbow builds: ursacomputing/crossbow @ actions-1452cb5f59
|
|
+1 |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit eddb2b9. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this pull request
Aug 20, 2023
…e#36945) ### Rationale for this change `build_google_cloud_cpp_storage()` calls `resolve_dependency(OpenSSL)` but it should not be here. We should have only one `resolve_dependency(OpenSSL)` for easy to maintain. ### What changes are included in this PR? Don't call `resolve_dependency(OpenSSL)` from `build_google_cloud_cpp_storage()`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#36944 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…e#36945) ### Rationale for this change `build_google_cloud_cpp_storage()` calls `resolve_dependency(OpenSSL)` but it should not be here. We should have only one `resolve_dependency(OpenSSL)` for easy to maintain. ### What changes are included in this PR? Don't call `resolve_dependency(OpenSSL)` from `build_google_cloud_cpp_storage()`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#36944 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
build_google_cloud_cpp_storage()callsresolve_dependency(OpenSSL)but it should not be here. We should have only oneresolve_dependency(OpenSSL)for easy to maintain.What changes are included in this PR?
Don't call
resolve_dependency(OpenSSL)frombuild_google_cloud_cpp_storage().Are these changes tested?
Yes.
Are there any user-facing changes?
No.