Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FlightRPC][Python] Add ServerCallContext::AddHeader/AddTrailer #36952

Closed
lidavidm opened this issue Jul 31, 2023 · 0 comments · Fixed by #36956
Closed

[C++][FlightRPC][Python] Add ServerCallContext::AddHeader/AddTrailer #36952

lidavidm opened this issue Jul 31, 2023 · 0 comments · Fixed by #36956
Assignees
@lidavidm
Labels
Component: C++ Component: FlightRPC Component: Python Type: enhancement
Milestone
14.0.0

Comments

@lidavidm
Copy link
Member

Describe the enhancement requested

This is useful for directly adding headers without futzing around with interceptors or FlightStatusDetail (which was a design mistake compounded from the original design mistake of trying to reuse arrow::Status for Flight error handling).

Component(s)

C++, FlightRPC, Python
@lidavidm lidavidm added this to the 14.0.0 milestone Jul 31, 2023
@lidavidm lidavidm self-assigned this Jul 31, 2023
lidavidm added a commit to lidavidm/arrow that referenced this issue Jul 31, 2023
@lidavidm
apacheGH-36952: [C++][FlightRPC][Python] Add methods to send headers
8618c61
lidavidm added a commit to lidavidm/arrow that referenced this issue Jul 31, 2023
@lidavidm
apacheGH-36952: [C++][FlightRPC][Python] Add methods to send headers
86cf894
@github-actions github-actions bot mentioned this issue Jul 31, 2023
Merged
lidavidm added a commit to lidavidm/arrow that referenced this issue Jul 31, 2023
@lidavidm
apacheGH-36952: [C++][FlightRPC][Python] Add methods to send headers
56556e4
kou pushed a commit that referenced this issue Jul 31, 2023
@lidavidm
GH-36952: [C++][FlightRPC][Python] Add methods to send headers (#36956)
37cb592 
### Rationale for this change

Sending headers/trailers is required for services, but you couldn't do this before.

### What changes are included in this PR?

Add new methods to directly send headers/trailers.

### Are these changes tested?

Yes

### Are there any user-facing changes?

Yes (new APIs)

* Closes: #36952

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@lidavidm @R-JunmingChen
apacheGH-36952: [C++][FlightRPC][Python] Add methods to send headers (a…
fef683c 
…pache#36956)

### Rationale for this change

Sending headers/trailers is required for services, but you couldn't do this before.

### What changes are included in this PR?

Add new methods to directly send headers/trailers.

### Are these changes tested?

Yes

### Are there any user-facing changes?

Yes (new APIs)

* Closes: apache#36952

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@lidavidm @loicalleyne
apacheGH-36952: [C++][FlightRPC][Python] Add methods to send headers (a…
0c184d1 
…pache#36956)

### Rationale for this change

Sending headers/trailers is required for services, but you couldn't do this before.

### What changes are included in this PR?

Add new methods to directly send headers/trailers.

### Are these changes tested?

Yes

### Are there any user-facing changes?

Yes (new APIs)

* Closes: apache#36952

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
Component: C++ Component: FlightRPC Component: Python Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36952: [C++][FlightRPC][Python] Add methods to send headers lidavidm/arrow
1 participant
@lidavidm