Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FlightRPC] FlightDataDeserialize incorrectly rejects unknown field tags #36975

Closed
lidavidm opened this issue Aug 1, 2023 · 0 comments · Fixed by #36979
Closed

[C++][FlightRPC] FlightDataDeserialize incorrectly rejects unknown field tags #36975

lidavidm opened this issue Aug 1, 2023 · 0 comments · Fixed by #36979
Assignees
@lidavidm
Labels
Component: C++ Component: FlightRPC Type: bug
Milestone
14.0.0

Comments

@lidavidm
Copy link
Member

lidavidm commented Aug 1, 2023

Describe the bug, including details regarding any error messages, version, and platform.

#32276 (comment)

arrow/cpp/src/arrow/flight/transport/grpc/serialization_internal.cc

Lines 379 to 380 in 66a6136

default:
DCHECK(false) << "cannot happen";

Component(s)

C++, FlightRPC
@lidavidm lidavidm added this to the 14.0.0 milestone Aug 1, 2023
@lidavidm lidavidm self-assigned this Aug 1, 2023
@lidavidm lidavidm mentioned this issue Aug 1, 2023
Open
lidavidm added a commit to lidavidm/arrow that referenced this issue Aug 1, 2023
@lidavidm
apacheGH-36975: [C++][FlightRPC] Skip unknown fields, don't crash
0315f63
@github-actions github-actions bot mentioned this issue Aug 1, 2023
Merged
lidavidm added a commit to lidavidm/arrow that referenced this issue Aug 1, 2023
@lidavidm
apacheGH-36975: [C++][FlightRPC] Skip unknown fields, don't crash
65a06ab
@kou kou closed this as completed in #36979 Aug 1, 2023
kou pushed a commit that referenced this issue Aug 1, 2023
@lidavidm
GH-36975: [C++][FlightRPC] Skip unknown fields, don't crash (#36979)
0edef8c 
### Rationale for this change

We should skip unknown fields instead of crashing, for forwards compatibility. 

### What changes are included in this PR?

Skip unknown fields in the FlightData deserializer.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #36975

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@lidavidm @loicalleyne
apacheGH-36975: [C++][FlightRPC] Skip unknown fields, don't crash (ap…
1c25a1f 
…ache#36979)

### Rationale for this change

We should skip unknown fields instead of crashing, for forwards compatibility. 

### What changes are included in this PR?

Skip unknown fields in the FlightData deserializer.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#36975

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
Component: C++ Component: FlightRPC Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36975: [C++][FlightRPC] Skip unknown fields, don't crash lidavidm/arrow
1 participant
@lidavidm